Hi
The following Fixes line in commit log emits no warning:
Fixes: Use packed mode for 32 bits per word transfers to increase
Neither does a fixes with mismatched commit description:
Fixes: e4da63cda51f ("networking: packet_mmap: fix old config reference")
which should have been infact:
Fixes: e4da63cda51f ("docs: networking: packet_mmap: fix old config
reference")
I could work on this if Lukas and Joe are okay with it.
Thank you,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Hi
The following Fixes line in commit log emits no warning:
Fixes: Use packed mode for 32 bits per word transfers to increase
Neither does a fixes with mismatched commit description:
Fixes: e4da63cda51f ("networking: packet_mmap: fix old config reference")
which should have been infact:
Fixes: e4da63cda51f ("docs: networking: packet_mmap: fix old config
reference")
I could work on this if Lukas and Joe are okay with it.
Sounds good to me. Although I always thought checkpatch already has
such a check... we do check commit sha ("description"); so checking
Fixes can reuse that checking.
Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Hi
The following Fixes line in commit log emits no warning:
Fixes: Use packed mode for 32 bits per word transfers to increase
Neither does a fixes with mismatched commit description:
Fixes: e4da63cda51f ("networking: packet_mmap: fix old config reference")
which should have been infact:
Fixes: e4da63cda51f ("docs: networking: packet_mmap: fix old config
reference")
I could work on this if Lukas and Joe are okay with it.
It's not really a solvable problem as the SHA1 probably exists in an
individual local tree.
Joe, so did you deactivate checking Fixes: at some point?
We can always check if it makes locally sense; that still does not
avoid the situation when a Fixes to an individual local tree and later
during integration hashes change, but it does sanity-checking on Fixes
tags for the hashes and descriptions that are stable.
Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
From: Joe Perches <joe@perches.com> Date: 2021-01-12 06:23:27
On Tue, 2021-01-12 at 07:08 +0100, Lukas Bulwahn wrote:
We can always check if it makes locally sense; that still does not
avoid the situation when a Fixes to an individual local tree and later
during integration hashes change, but it does sanity-checking on Fixes
tags for the hashes and descriptions that are stable.
Again: it's not a solvable problem. I'd rather not generate
warnings on problems that are not obviously correct.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Hi
The following Fixes line in commit log emits no warning:
Fixes: Use packed mode for 32 bits per word transfers to increase
Neither does a fixes with mismatched commit description:
Fixes: e4da63cda51f ("networking: packet_mmap: fix old config reference")
which should have been infact:
Fixes: e4da63cda51f ("docs: networking: packet_mmap: fix old config
reference")
I could work on this if Lukas and Joe are okay with it.
It's not really a solvable problem as the SHA1 probably exists in an
individual local tree.
Joe, so did you deactivate checking Fixes: at some point?
No, Fixes: lines were always just skipped if it matched:
$line =~ /^\s*Fixes:\s*[0-9a-z]{12,40}/i
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Hi
The following Fixes line in commit log emits no warning:
Fixes: Use packed mode for 32 bits per word transfers to increase
Neither does a fixes with mismatched commit description:
Fixes: e4da63cda51f ("networking: packet_mmap: fix old config reference")
which should have been infact:
Fixes: e4da63cda51f ("docs: networking: packet_mmap: fix old config
reference")
I could work on this if Lukas and Joe are okay with it.
It's not really a solvable problem as the SHA1 probably exists in an
individual local tree.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees