Thread (16 messages) 16 messages, 5 authors, 2020-10-15

Re: [Linux-kernel-mentees] [PATCH] lib: kunit: add test_min_heap test conversion to KUnit

From: Brendan Higgins via Linux-kernel-mentees <hidden>
Date: 2020-10-12 21:03:11
Also in: linux-kselftest, lkml

On Tue, Aug 4, 2020 at 9:22 AM Vitor Massaru Iha [off-list ref] wrote:
Hi Peter,

On Tue, Aug 4, 2020 at 11:23 AM [off-list ref] wrote:
quoted
On Tue, Aug 04, 2020 at 10:46:21AM -0300, Vitor Massaru Iha wrote:
quoted
On Tue, Aug 4, 2020 at 10:25 AM [off-list ref] wrote:
quoted
On Wed, Jul 29, 2020 at 06:57:17PM -0300, Vitor Massaru Iha wrote:
quoted
The results can be seen this way:

This is an excerpt from the test.log with the result in TAP format:
[snip]
ok 5 - example
    # Subtest: min-heap
    1..6
    ok 1 - test_heapify_all_true
    ok 2 - test_heapify_all_false
    ok 3 - test_heap_push_true
    ok 4 - test_heap_push_false
    ok 5 - test_heap_pop_push_true
    ok 6 - test_heap_pop_push_false
[snip]
So ^ is TAP format?
Yep, you can see the spec here: https://testanything.org/tap-specification.html
quoted
quoted
quoted
I don't care or care to use either; what does dmesg do? It used to be
that just building the self-tests was sufficient and any error would
show in dmesg when you boot the machine.

But if I now have to use some damn tool, this is a regression.
If you don't want to, you don't need to use the kunit-tool. If you
compile the tests as builtin and run the Kernel on your machine
the test result will be shown in dmesg in TAP format.
That's seems a lot more verbose than it is now. I've recently even done
a bunch of tests that don't print anything on success, dmesg is clutter
enough already.
What tests do you refer to?

Running the test_min_heap.c, I got this from dmesg:

min_heap_test: test passed

And running min_heap_kunit.c:

ok 1 - min-heap
Gentle poke. I think Vitor was looking for a response. My guess is
that Ian was waiting for a follow up patch.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help