Re: [PATCH 25/61] net/bluetooth: Prefer IS_ERR_OR_NULL over manual NULL check
From: Bastien Nocera <hadess@hadess.net>
Date: 2026-03-10 13:56:08
Also in:
amd-gfx, bpf, ceph-devel, cocci, dm-devel, dri-devel, gfs2, intel-gfx, intel-wired-lan, kvm, linux-block, linux-bluetooth, linux-btrfs, linux-cifs, linux-clk, linux-ext4, linux-fsdevel, linux-gpio, linux-hyperv, linux-input, linux-leds, linux-media, linux-mips, linux-mm, linux-modules, linux-nfs, linux-omap, linux-phy, linux-pm, linux-rockchip, linux-s390, linux-scsi, linux-sctp, linux-security-module, linux-sh, linux-sound, linux-trace-kernel, linux-usb, linux-wireless, lkml, netdev, ntfs3, sched-ext, target-devel, v9fs
On Tue, 2026-03-10 at 12:48 +0100, Philipp Hahn wrote:
Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL check. Change generated with coccinelle. To: Marcel Holtmann <marcel@holtmann.org> To: Johan Hedberg <redacted> To: Luiz Augusto von Dentz <luiz.dentz@gmail.com> Cc: linux-bluetooth@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Philipp Hahn <redacted>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
quoted hunk ↗ jump to hunk
--- net/bluetooth/mgmt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.cindex a7238fd3b03bb54f39af1afee74dc1acd931c324..06d2da67bbe14e17ee478aa939d e26526c333d91 100644--- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c@@ -4169,7 +4169,7 @@ static void set_default_phy_complete(structhci_dev *hdev, void *data, int err) mgmt_phy_configuration_changed(hdev, cmd->sk); } - if (skb && !IS_ERR(skb)) + if (!IS_ERR_OR_NULL(skb)) kfree_skb(skb); mgmt_pending_free(cmd);@@ -5730,7 +5730,7 @@ static void read_local_oob_data_complete(structhci_dev *hdev, void *data, MGMT_STATUS_SUCCESS, &mgmt_rp, rp_size); remove: - if (skb && !IS_ERR(skb)) + if (!IS_ERR_OR_NULL(skb)) kfree_skb(skb); mgmt_pending_free(cmd);@@ -8277,7 +8277,7 @@ static voidread_local_oob_ext_data_complete(struct hci_dev *hdev, void *data, mgmt_rp, sizeof(*mgmt_rp) + eir_len, HCI_MGMT_OOB_DATA_EVENTS, cmd->sk); done: - if (skb && !IS_ERR(skb)) + if (!IS_ERR_OR_NULL(skb)) kfree_skb(skb); kfree(mgmt_rp);