# Re: Re: \[PATCH\] tpm: Add missing check in tpm\_inf\_recv

- From: \<hidden\>
- Date: 2021-03-01 11:32:24 
- List: linux-integrity
- Page: https://ratatoskr.run/linux-integrity/2021/03/6281374
- Thread: https://ratatoskr.run/linux-integrity/2021/02/6280822/t.md

```text


&quot;Jarkko Sakkinen&quot; &lt;jarkko@kernel.org&gt;写道：
> On Sun, Feb 28, 2021 at 05:32:30PM +0800, Dinghao Liu wrote:
> > The use of wait() in tpm_inf_recv() is almost the same. It's odd that
> > we only check the return value and terminate execution flow of one call.
> > 
> > Signed-off-by: Dinghao Liu <redacted>
> 
> Is the unchecked return value of wait() the problem? I don't see the
> function even mentioned in the description.
> 

Yes. This issue is reported by my static analysis tool. I think we
should treat wait() equally in this function (check the return value
and return an error code on failure). 

Regards,
Dinghao
```
