# Re: \[PATCH\] tpm: WARN\_ONCE() -\> pr\_warn\_once() in tpm\_tis\_status()

- From: Jarkko Sakkinen \<jarkko@kernel.org\>
- Date: 2021-02-02 22:06:43 
- List: linux-integrity
- Page: https://ratatoskr.run/linux-integrity/2021/02/6871579
- Thread: https://ratatoskr.run/linux-integrity/2021/02/6871544/t.md

```text
On Tue, Feb 02, 2021 at 07:43:04AM -0800, Guenter Roeck wrote:
> On 2/2/21 7:33 AM, jarkko@kernel.org wrote:
> > From: Jarkko Sakkinen <jarkko@kernel.org>
> > 
> > An unexpected status from TPM chip is not irrecovable failure of the
> > kernel. It's only undesirable situation. Thus, change the WARN_ONCE
> > instance inside tpm_tis_status() to pr_warn_once().
> > 
> > In addition: print the status in the log message because it is actually
> > useful information lacking from the existing log message.
> > 
> > Suggested-by:  Guenter Roeck <linux@roeck-us.net>
> > Cc: <redacted>
> > Fixes: 6f4f57f0b909 ("tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()")
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Thanks.

/Jarkko
```
