# Re: \[PATCH v5 1/2\] tpm: add sysfs exports for all banks of PCR registers

- From: Jarkko Sakkinen \<jarkko@kernel.org\>
- Date: 2021-01-15 06:49:12 
- List: linux-integrity
- Page: https://ratatoskr.run/linux-integrity/2021/01/13329990
- Thread: https://ratatoskr.run/linux-integrity/2021/01/13329981/t.md

```text
On Wed, Jan 13, 2021 at 03:26:33PM -0800, James Bottomley wrote:
> Create sysfs per hash groups with 24 PCR files in them one group,
> named pcr-<hash>, for each agile hash of the TPM.  The files are
> plugged in to a PCR read function which is TPM version agnostic, so
> this works also for TPM 1.2 but the hash is only sha1 in that case.
> 
> Note: the macros used to create the hashes emit spurious checkpatch
> warnings.  Do not try to "fix" them as checkpatch recommends, otherwise
> they'll break.
> 
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> Reviewed-by: Jerry Snitselaar <redacted>
> Tested-by: Thiago Jung Bauermann <redacted>
> 
> ---

Tested-by: Jarkko Sakkinen <jarkko@kernel.org>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

/Jarkko

```