Thread (4 messages) 4 messages, 4 authors, 2020-06-08

Re: [PATCH] ima: Remove __init annotation from ima_pcrread()

From: Mimi Zohar <zohar@linux.ibm.com>
Date: 2020-06-08 13:16:26
Also in: lkml, stable

Hi Roberto,

On Sun, 2020-06-07 at 23:00 +0200, Roberto Sassu wrote:
Commit 6cc7c266e5b4 ("ima: Call ima_calc_boot_aggregate() in
ima_eventdigest_init()") added a call to ima_calc_boot_aggregate() so that
the digest can be recalculated for the boot_aggregate measurement entry if
the 'd' template field has been requested. For the 'd' field, only SHA1 and
MD5 digests are accepted.

Given that ima_eventdigest_init() does not have the __init annotation, all
functions called should not have it. This patch removes __init from
ima_pcrread().

Cc: stable@vger.kernel.org
Fixes:  6cc7c266e5b4 ("ima: Call ima_calc_boot_aggregate() in ima_eventdigest_init()")
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Thank you for fixing this so quickly!  Jerry, Bruno, thank you for the
Reviews.  This patch is in Linus' tree as: 8b8c704d913b ("ima: Remove
__init annotation from ima_pcrread()".

Mimi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help