Inter-revision diff: patch 5

Comparing v4 (message) to v2 (message)

--- v4
+++ v2
@@ -1,14 +1,9 @@
-The LEDs can only by turned on/off, so max_brightness should be set to 1.
-Without this the max_brightness sysfs-attribute will report 255 which is
-wrong.
+The LEDs can only by turned on/off, so max_brightness should be set to 1
+(aka LED_ON). Without this the max_brightness sysfs-attribute will report
+255 which is wrong.
 
-Reviewed-by: Marek Behún <kabel@kernel.org>
-Acked-by: Pavel Machek <pavel@ucw.cz>
 Signed-off-by: Hans de Goede <hdegoede@redhat.com>
 ---
-Changes in v3:
-- Use 1 instead of LED_ON
-
 Changes in v2:
 - New patch in v2 of this patch-set
 ---
@@ -16,22 +11,22 @@
  1 file changed, 2 insertions(+)
 
 diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c
-index 1b8dd85ceb05..668762663f69 100644
+index bb8e5ebdaabe..d936edb88f07 100644
 --- a/drivers/hid/hid-lenovo.c
 +++ b/drivers/hid/hid-lenovo.c
-@@ -822,6 +822,7 @@ static int lenovo_register_leds(struct hid_device *hdev)
+@@ -816,6 +816,7 @@ static int lenovo_register_leds(struct hid_device *hdev)
  
  	data->led_mute.name = name_mute;
  	data->led_mute.brightness_set_blocking = lenovo_led_brightness_set;
-+	data->led_mute.max_brightness = 1;
++	data->led_mute.max_brightness = LED_ON;
  	data->led_mute.flags = LED_HW_PLUGGABLE;
  	data->led_mute.dev = &hdev->dev;
  	ret = led_classdev_register(&hdev->dev, &data->led_mute);
-@@ -830,6 +831,7 @@ static int lenovo_register_leds(struct hid_device *hdev)
+@@ -824,6 +825,7 @@ static int lenovo_register_leds(struct hid_device *hdev)
  
  	data->led_micmute.name = name_micm;
  	data->led_micmute.brightness_set_blocking = lenovo_led_brightness_set;
-+	data->led_micmute.max_brightness = 1;
++	data->led_micmute.max_brightness = LED_ON;
  	data->led_micmute.flags = LED_HW_PLUGGABLE;
  	data->led_micmute.dev = &hdev->dev;
  	ret = led_classdev_register(&hdev->dev, &data->led_micmute);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help