Inter-revision diff: patch 6

Comparing v6 (message) to v2 (message)

--- v6
+++ v2
@@ -1,36 +1,108 @@
-As described in the board hardware user guide IMX53RQSBRM-R.pdf, the
-mc34708 pin PWRON1 is connected to a button "SW6"/"POWER", connecting
-this line to GND.
-Add support for the imx53-qsrb "POWER" button.
+Add a buttons node and properties describing the "ONOFD" (MC13783) and
+"PWRON" (MC13892/MC34708) buttons available in the fsl,mc13xxx PMIC ICs.
 
 Signed-off-by: Alexander Kurz <akurz@blala.de>
 ---
- arch/arm/boot/dts/nxp/imx/imx53-qsrb.dts | 12 ++++++++++++
- 1 file changed, 12 insertions(+)
+ .../devicetree/bindings/mfd/fsl,mc13xxx.yaml  | 58 +++++++++++++++++++
+ 1 file changed, 58 insertions(+)
 
-diff --git a/arch/arm/boot/dts/nxp/imx/imx53-qsrb.dts b/arch/arm/boot/dts/nxp/imx/imx53-qsrb.dts
-index 2f06ad61a766..2a6d28e9e8f8 100644
---- a/arch/arm/boot/dts/nxp/imx/imx53-qsrb.dts
-+++ b/arch/arm/boot/dts/nxp/imx/imx53-qsrb.dts
-@@ -139,6 +139,18 @@ vgen2_reg: vgen2 {
- 				regulator-always-on;
- 			};
- 		};
+diff --git a/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml b/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
+index 94e2f6557376..761267b42c85 100644
+--- a/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
++++ b/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
+@@ -39,6 +39,41 @@ properties:
+   interrupts:
+     maxItems: 1
+ 
++  buttons:
++    type: object
++    $ref: /schemas/input/input.yaml#
++    description: Buttons
++    properties:
++      reg:
++        description: |
++          One of
++          MC13783 BUTTON IDs:
++            0: ONOFD1
++            1: ONOFD2
++            2: ONOFD3
++          MC13892 BUTTON IDs:
++            0: PWRON1
++            1: PWRON2
++            2: PWRON3
++          MC34708 BUTTON IDs:
++            0: PWRON1
++            1: PWRON2
 +
-+		buttons {
-+			#address-cells = <1>;
-+			#size-cells = <0>;
-+			onkey@0 {
-+				reg = <0>;
-+				linux,code = <KEY_POWER>;
-+				debounce-delay-ms = <30>;
-+				active-low;
-+				fsl,enable-reset;
-+			};
-+		};
- 	};
- };
++      debounce-delay-ms:
++        enum: [0, 30, 150, 750]
++        default: 30
++        description: |
++          Sets the debouncing delay in milliseconds.
++          Valid values: 0, 30, 150 and 750ms.
++
++      active-low:
++        description: Set active when pin is pulled low.
++
++      fsl,enable-reset:
++        description: |
++          Setting of the global reset option.
++        type: boolean
++
+   leds:
+     type: object
+     $ref: /schemas/leds/common.yaml#
+@@ -119,6 +154,10 @@ allOf:
+             const: fsl,mc13783
+     then:
+       properties:
++        buttons:
++          properties:
++            reg:
++              enum: [0, 1, 2]
+         leds:
+           properties:
+             fsl,led-control:
+@@ -137,6 +176,10 @@ allOf:
+             const: fsl,mc13892
+     then:
+       properties:
++        buttons:
++          properties:
++            reg:
++              enum: [0, 1, 2]
+         leds:
+           properties:
+             fsl,led-control:
+@@ -155,6 +198,10 @@ allOf:
+             const: fsl,mc34708
+     then:
+       properties:
++        buttons:
++          properties:
++            reg:
++              enum: [0, 1]
+         leds:
+           properties:
+             fsl,led-control:
+@@ -183,6 +230,17 @@ examples:
+             fsl,mc13xxx-uses-rtc;
+             fsl,mc13xxx-uses-adc;
  
++            buttons {
++                #address-cells = <1>;
++                #size-cells = <0>;
++                onkey1@0 {
++                    reg = <0>;
++                    debounce-delay-ms = <30>;
++                    active-low;
++                    fsl,enable-reset;
++                };
++            };
++
+             leds {
+                 #address-cells = <1>;
+                 #size-cells = <0>;
 -- 
 2.39.5
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help