Inter-revision diff: cover letter

Comparing v1 (message) to v5 (message)

--- v1
+++ v5
@@ -4,43 +4,73 @@
 representing a port that support USB PD charging.
 
 Allows userspace to display to the user if the machine is charging and
-on which port, and if another device is being charged by a port. Also
-allows to limit the current draw for thermal reasons.
+on which port, and if another device is being charged by a port.
 
 Thanks,
 
 Tomeu
 
+Changes in v5:
+- Check explicitly for !EC_RES_SUCCESS as suggested by Benson Leung.
+- Fix type of variable passed to do_div.
 
-Benson Leung (1):
-  power_supply: Add types for USB Type C and PD chargers
+Changes in v4:
+- Calculate correctly the size of the payloads in
+  cros_ec_get_host_command_version_mask.
+- Declare size parameters in ec_command as size_t
+
+Changes in v3:
+- Remove duplicated prototype of cros_ec_get_host_event.
+- Use do_div so it builds on 32bit (suggested by 0-day kbuild bot).
+- Remove sysfs attributes ext_current_lim and ext_voltage_lim because
+  I don't know yet where they should be placed (and don't have HW to
+  test them).
+- Remove superfluous pre-allocated buffers ec_inbuf and ec_outbuf.
+- Lots of misc comments from Stephen Boyd were addressed.
+- Unregister notification listener in .remove callback.
+- Only register the PD charger device if there are any PD ports in this
+  EC.
+- Dropped patch using EC_CMD_GET_FEATURES to decide whether to create a
+  charger device because we are now only creating one if a EC has any PD
+  ports.
+- Dropped patch adding power_supply types because it has been merged
+  already.
+
+Changes in v2:
+- Allocate enough for the structs in cros_ec_get_host_command_version_mask,
+  not their pointers.
+- Allocate msg in the stack in get_next_event and
+  get_keyboard_state_event, as suggested by Gwendal.
+- Split out changes to cros_ec_commands.h and the helpers added to
+  mfd/cros_ec.h from the patch that adds the charger driver, as
+  suggested by Lee.
+- Actually call get_ec_num_ports.
+- Move cros_ec_usb_pd_charger_register into cros_ec_dev.c.
 
 Sameer Nanda (1):
   power: cros_usbpd-charger: Add EC-based USB PD charger driver
 
-Tomeu Vizoso (2):
-  mfd: cros_ec: small kerneldoc fix
+Tomeu Vizoso (4):
+  mfd: cros_ec: Add cros_ec_cmd_xfer_status helper
+  mfd: cros_ec: Add cros_ec_get_host_event
+  mfd: cros_ec: Add more definitions for PD commands
   platform/chrome: Register USB PD charger device
 
 Vic Yang (1):
   mfd: cros_ec: Add MKBP event support
 
-Vincent Palatin (1):
-  platform/chrome: Check the USB PD feature before creating a charger
-
- drivers/input/keyboard/cros_ec_keyb.c   | 135 ++---
- drivers/mfd/cros_ec.c                   |  72 ++-
- drivers/platform/chrome/cros_ec_dev.c   |  72 +++
- drivers/platform/chrome/cros_ec_proto.c | 139 +++++
+ drivers/input/keyboard/cros_ec_keyb.c   | 135 ++----
+ drivers/mfd/cros_ec.c                   |  57 ++-
+ drivers/platform/chrome/cros_ec_dev.c   |  44 ++
+ drivers/platform/chrome/cros_ec_proto.c | 129 ++++++
  drivers/power/Kconfig                   |  10 +
  drivers/power/Makefile                  |   1 +
- drivers/power/cros_usbpd-charger.c      | 907 ++++++++++++++++++++++++++++++++
- drivers/power/power_supply_sysfs.c      |   3 +-
- include/linux/mfd/cros_ec.h             |  77 ++-
- include/linux/mfd/cros_ec_commands.h    | 442 +++++++++++++++-
- include/linux/power_supply.h            |   3 +
- 11 files changed, 1747 insertions(+), 114 deletions(-)
+ drivers/power/cros_usbpd-charger.c      | 780 ++++++++++++++++++++++++++++++++
+ include/linux/mfd/cros_ec.h             |  62 +++
+ include/linux/mfd/cros_ec_commands.h    | 358 ++++++++++++++-
+ 9 files changed, 1464 insertions(+), 112 deletions(-)
  create mode 100644 drivers/power/cros_usbpd-charger.c
 
 -- 
 2.5.0
+
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help