--- v5
+++ v2
@@ -2,19 +2,24 @@
Hi,
-This is hopefully the final revision of this patch series. Patch v4 had
-a rebase issue of a part of the sensors patch for which a part had moved
-to the end of the series. This has been fixed. I have double, no triple
-checked the patches. Made sure they build using a 'rebase -x' script
-and also ran the hid-tools tests on the final driver.
+I would like to share an updated version of the hid-playstation driver.
+This new revision is very similar to the original release, but with
+various small changes and minor improvements. Thanks to everyone who
+provided feedback through the mailing list or privately.
-Thanks to everyone who provided feedback through the mailing list or privately.
-As suggested by Benjamin on the 'v4' version of this email, if you were
-involed in the review or testing of this series and would like some credit,
-please provide a reviewed-by or tested-by tag.
-
-Changes since v4:
-- Fixed bad rebase of ps_sensors_create, moved it to appropriate patch.
+Changes since v1:
+- Export ps_devices table using MODULE_DEVICE_TABLE.
+- Uses 'width - 1' and 'height - 1' for touchpad ABS_MT_POSITION_X/Y.
+- Uses 'sysfs_emit' instead of 'snprintf' in sysfs show functions.
+- Switched to devm_device_add_group to manage attribute groups.
+- Changed player LED lookup to use pointer calculations instead of a loop.
+- Added readonly mute set_brightness call to silence ENOTSUP.
+- Lightbar is not dynamically allocated and now allocated as part of 'struct dualsense'
+- Size checking on hid_hw_raw_request for calibration, firmware and mac addrees info.
+- Replaced magic constants with defines e.g. for HID version or output report values.
+- Minor code changes e.g. const changes.
+- Uses container_of to retrieve 'struct ps_device' from 'struct dualsense'.
+- Added an explicit module_init/module_exit to clean up the player IDA.
Thanks,
@@ -37,11 +42,12 @@
HID: playstation: report DualSense hardware and firmware version.
MAINTAINERS | 6 +
- drivers/hid/Kconfig | 21 +
+ drivers/hid/Kconfig | 20 +
drivers/hid/Makefile | 1 +
drivers/hid/hid-ids.h | 1 +
- drivers/hid/hid-playstation.c | 1492 +++++++++++++++++++++++++++++++++
- 5 files changed, 1521 insertions(+)
+ drivers/hid/hid-playstation.c | 1448 +++++++++++++++++++++++++++++++++
+ drivers/hid/hid-quirks.c | 4 +
+ 6 files changed, 1480 insertions(+)
create mode 100644 drivers/hid/hid-playstation.c
--