# Re: \[PATCH v2 1/4\] Input: elo - fix style issues

- From: Dmitry Torokhov \<dmitry.torokhov@gmail.com\>
- Date: 2026-03-02 00:25:16 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2026/03/3434342
- Thread: https://ratatoskr.run/linux-input/2026/02/3433648/t.md

```text
Hi Josh,

On Sat, Feb 28, 2026 at 07:52:58PM +0000, Josh Law wrote:
> Fix array constness and spacing issues reported by checkpatch.
> 
> Signed-off-by: Josh Law <redacted>

Why the difference between From: and Signed-off-by?

> ---
>  drivers/input/touchscreen/elo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/elo.c b/drivers/input/touchscreen/elo.c
> index 434b9b47e964..40ae132cde21 100644
> --- a/drivers/input/touchscreen/elo.c
> +++ b/drivers/input/touchscreen/elo.c
> @@ -257,7 +257,7 @@ static int elo_command_10(struct elo *elo, unsigned char *packet)
>  
>  static int elo_setup_10(struct elo *elo)
>  {
> -	static const char *elo_types[] = { "Accu", "Dura", "Intelli", "Carroll" };
> +	static const char * const elo_types[] = { "Accu", "Dura", "Intelli", "Carroll" };
>  	struct input_dev *dev = elo->dev;
>  	unsigned char packet[ELO10_PACKET_LEN] = { ELO10_ID_CMD };
>  
> @@ -273,7 +273,7 @@ static int elo_setup_10(struct elo *elo)
>  
>  	dev_info(&elo->serio->dev,
>  		 "%sTouch touchscreen, fw: %02x.%02x, features: 0x%02x, controller: 0x%02x\n",
> -		 elo_types[(packet[1] -'0') & 0x03],
> +		 elo_types[(packet[1] - '0') & 0x03],
>  		 packet[5], packet[4], packet[3], packet[7]);
>  
>  	return 0;

Thanks.

-- 
Dmitry
```