[PATCH v3] Input: bcm5974 - Driver cleanup by replacing dprintk with dev_dbg
From: Bhanu Seshu Kumar Valluri <hidden>
Date: 2025-09-03 08:55:14
Also in:
linux-kernel-mentees, lkml
Subsystem:
apple bcm5974 multitouch driver, input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers:
Henrik Rydberg, Dmitry Torokhov, Linus Torvalds
Debug printk messages are converted to dev_dbg based logs for better control over debug messages using dynamic logging. Signed-off-by: Bhanu Seshu Kumar Valluri <redacted> --- Changes in V3 1. Name in the from tag & signed-off tag are matched. Note: This patch is tested for compilation. v1 patch : https://lore.kernel.org/all/20250902164351.36828-1-bhanuseshukumar@gmail.com/ (local) v2 patch : https://lore.kernel.org/all/20250903061908.41910-1-bhanuseshukumar@gmail.com/ (local) drivers/input/mouse/bcm5974.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index dfdfb59cc8b5..03e112666c2e 100644
--- a/drivers/input/mouse/bcm5974.c
+++ b/drivers/input/mouse/bcm5974.c@@ -156,13 +156,6 @@ MODULE_AUTHOR("Henrik Rydberg"); MODULE_DESCRIPTION("Apple USB BCM5974 multitouch driver"); MODULE_LICENSE("GPL"); -#define dprintk(level, format, a...)\ - { if (debug >= level) printk(KERN_DEBUG format, ##a); } - -static int debug = 1; -module_param(debug, int, 0644); -MODULE_PARM_DESC(debug, "Activate debugging output"); - /* button data structure */ struct bt_data { u8 unknown1; /* constant */
@@ -550,8 +543,7 @@ static int report_bt_state(struct bcm5974 *dev, int size) if (size != sizeof(struct bt_data)) return -EIO; - dprintk(7, - "bcm5974: button data: %x %x %x %x\n", + dev_dbg(&dev->intf->dev, "button data: %x %x %x %x\n", dev->bt_data->unknown1, dev->bt_data->button, dev->bt_data->rel_x, dev->bt_data->rel_y);
@@ -688,7 +680,7 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on) goto out; } - dprintk(2, "bcm5974: switched to %s mode.\n", + dev_dbg(&dev->intf->dev, "switched to %s mode.\n", on ? "wellspring" : "normal"); out:
@@ -718,7 +710,7 @@ static void bcm5974_irq_button(struct urb *urb) } if (report_bt_state(dev, dev->bt_urb->actual_length)) - dprintk(1, "bcm5974: bad button package, length: %d\n", + dev_dbg(&intf->dev, "bad button package, length: %d\n", dev->bt_urb->actual_length); exit:
@@ -753,7 +745,7 @@ static void bcm5974_irq_trackpad(struct urb *urb) goto exit; if (report_tp_state(dev, dev->tp_urb->actual_length)) - dprintk(1, "bcm5974: bad trackpad package, length: %d\n", + dev_dbg(&intf->dev, "bad trackpad package, length: %d\n", dev->tp_urb->actual_length); exit:
@@ -786,7 +778,7 @@ static int bcm5974_start_traffic(struct bcm5974 *dev) error = bcm5974_wellspring_mode(dev, true); if (error) { - dprintk(1, "bcm5974: mode switch failed\n"); + dev_dbg(&dev->intf->dev, "mode switch failed\n"); goto err_out; }
--
2.34.1