On 18/02/2024 16:10, Karel Balej wrote:

Rob Herring, 2024-02-15T08:20:52-06:00:

quoted

quoted

 .../bindings/mfd/marvell,88pm88x.yaml         | 74 +++++++++++++++++++

Filename should match the compatible.

In general, drop the 'x' wildcard.

By "in general", do you mean for the drivers code also?

No, not driver. The rules for wildcard, that they are discouraged, are
DT binding rules.

As I have mentioned in the commit message for the driver, the other
device is very similar and if the support for it was ever to be added
(which I personally currently have no interest in), I believe it would
make sense to extend this driver. Is it then still prefered to call it
all just 88pm886 now?

Extend the driver, it's unrelated. Binding still should be named like
compatible, because that extension might never happen.

quoted

quoted

+properties:
+  compatible:
+    const: marvell,88pm886-a1

So the file should be called marvell,88pm886-a1.yaml, correct? Again, is
it prefered to call it like this even if the other revision could
eventually be added (again, I am not interested in that right now

If you already add two devices, flexible name would be fine. But you do
not add it now and you might never add, so keep the filename=compatible.
It is fine if it has also other compatibles later. We already accepted
many bindings like that.


Best regards,
Krzysztof