# Re: \[PATCH 23/52\] input: pm8941-pwrkey - Convert to platform remove callback returning void

- From: Konrad Dybcio \<hidden\>
- Date: 2023-09-20 13:03:18 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2023/09/8295656
- Thread: https://ratatoskr.run/linux-arm-msm/2023/09/8295655/t.md

```text


On 9/20/23 14:58, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <redacted>
> ---
Reviewed-by: Konrad Dybcio <redacted>

Konrad
```