Re: [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Date: 2023-09-14 02:10:06
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2023-09-18 · Re: [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency · Jiri Kosina <jikos@kernel.org>
- 2023-09-14 · [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency · Randy Dunlap <hidden>
On Wed, 13 Sep, 2023 17:05:17 -0700 Randy Dunlap [off-list ref] wrote:
quoted hunk
The hid-nvidia-shield driver uses functions that are built only when LEDS_CLASS is set, so make the driver depend on that symbol to prevent build errors. riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L11': hid-nvidia-shield.c:(.text+0x192): undefined reference to `led_classdev_unregister' riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L113': hid-nvidia-shield.c:(.text+0xfa4): undefined reference to `led_classdev_register_ext' Fixes: 09308562d4af ("HID: nvidia-shield: Initial driver implementation with Thunderstrike support") Signed-off-by: Randy Dunlap <redacted> Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com> Cc: Jiri Kosina <redacted> Cc: Benjamin Tissoires <redacted> Cc: linux-input@vger.kernel.org --- drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/hid/Kconfig b/drivers/hid/Kconfig--- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig@@ -799,6 +799,7 @@ config HID_NVIDIA_SHIELD tristate "NVIDIA SHIELD devices" depends on USB_HID depends on BT_HIDP + depends on LEDS_CLASS help Support for NVIDIA SHIELD accessories.
Thanks for the patch. This also reminds me that the same needs to be done for POWER_SUPPLY since support was added for the controller's battery. I will send out a patch for that soon. Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>