[PATCH] HID: logitech-hidpp: add HIDPP_QUIRK_DELAYED_INIT for the T651.

Subsystems: hid core layer, hid logitech drivers, hid++ logitech drivers, the rest

STALE1146d LANDED

Landed in mainline as 5fe251112646 on 2023-06-19.

3 messages, 2 authors, 2023-06-19 · open the first message on its own page

[PATCH] HID: logitech-hidpp: add HIDPP_QUIRK_DELAYED_INIT for the T651.

From: Mike Hommey <hidden>
Date: 2023-06-17 23:47:43

498ba20690357691103de0f766960355247c78be put restarting communication
behind that flag, and this was apparently necessary on the T651, but the
flag was not set for it.

Signed-off-by: Mike Hommey <redacted>
---
 drivers/hid/hid-logitech-hidpp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index fdb66dc06582..4f227bc5c6b0 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -4299,7 +4299,7 @@ static const struct hid_device_id hidpp_devices[] = {
 	{ /* wireless touchpad T651 */
 	  HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH,
 		USB_DEVICE_ID_LOGITECH_T651),
-	  .driver_data = HIDPP_QUIRK_CLASS_WTP },
+	  .driver_data = HIDPP_QUIRK_CLASS_WTP | HIDPP_QUIRK_DELAYED_INIT },
 	{ /* Mouse Logitech Anywhere MX */
 	  LDJ_DEVICE(0x1017), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_1P0 },
 	{ /* Mouse logitech M560 */
-- 
2.41.0.6.ge371d37104

Re: [PATCH] HID: logitech-hidpp: add HIDPP_QUIRK_DELAYED_INIT for the T651.

From: Benjamin Tissoires <hidden>
Date: 2023-06-19 14:36:14

On Sun, 18 Jun 2023 08:09:57 +0900, Mike Hommey wrote:
498ba20690357691103de0f766960355247c78be put restarting communication
behind that flag, and this was apparently necessary on the T651, but the
flag was not set for it.
Applied to hid/hid.git (for-6.4/upstream-fixes), thanks!

[1/1] HID: logitech-hidpp: add HIDPP_QUIRK_DELAYED_INIT for the T651.
      https://git.kernel.org/hid/hid/c/5fe251112646

Cheers,
-- 
Benjamin Tissoires [off-list ref]

Re: [PATCH] HID: logitech-hidpp: add HIDPP_QUIRK_DELAYED_INIT for the T651.

From: Benjamin Tissoires <hidden>
Date: 2023-06-19 14:40:10

On Jun 19 2023, Benjamin Tissoires wrote:
On Sun, 18 Jun 2023 08:09:57 +0900, Mike Hommey wrote:
quoted
498ba20690357691103de0f766960355247c78be put restarting communication
behind that flag, and this was apparently necessary on the T651, but the
flag was not set for it.
Thanks for spotting this. I've amended the commit message to make
checkpatch.pl happier, and added the cc stable tags.

Cheers,
Benjamin
Applied to hid/hid.git (for-6.4/upstream-fixes), thanks!

[1/1] HID: logitech-hidpp: add HIDPP_QUIRK_DELAYED_INIT for the T651.
      https://git.kernel.org/hid/hid/c/5fe251112646

Cheers,
-- 
Benjamin Tissoires [off-list ref]

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help