Thread (28 messages) 28 messages, 3 authors, 2023-07-07
STALE1067d LANDED: 2 (0M)

[PATCH v4 17/24] Input: resistive-adc-touch - Simplify with dev_err_probe()

From: Krzysztof Kozlowski <hidden>
Date: 2023-06-25 16:30:12
Also in: lkml, platform-driver-x86
Subsystem: generic resistive touchscreen adc driver, input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers: Eugen Hristev, Dmitry Torokhov, Linus Torvalds

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <redacted>
Reviewed-by: Hans de Goede <redacted>
Reviewed-by: Andy Shevchenko <redacted>
---
 drivers/input/touchscreen/resistive-adc-touch.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/input/touchscreen/resistive-adc-touch.c b/drivers/input/touchscreen/resistive-adc-touch.c
index 6f754a8d30b1..7e761ec73273 100644
--- a/drivers/input/touchscreen/resistive-adc-touch.c
+++ b/drivers/input/touchscreen/resistive-adc-touch.c
@@ -210,12 +210,8 @@ static int grts_probe(struct platform_device *pdev)
 
 	/* get the channels from IIO device */
 	st->iio_chans = devm_iio_channel_get_all(dev);
-	if (IS_ERR(st->iio_chans)) {
-		error = PTR_ERR(st->iio_chans);
-		if (error != -EPROBE_DEFER)
-			dev_err(dev, "can't get iio channels.\n");
-		return error;
-	}
+	if (IS_ERR(st->iio_chans))
+		return dev_err_probe(dev, PTR_ERR(st->iio_chans), "can't get iio channels\n");
 
 	if (!device_property_present(dev, "io-channel-names"))
 		return -ENODEV;
-- 
2.34.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help