[PATCH] HID: wacom: Simplify comments

Subsystems: hid core layer, hid wacom driver, the rest

STALE1461d

4 messages, 3 authors, 2022-08-02 · open the first message on its own page

[PATCH] HID: wacom: Simplify comments

From: Christophe JAILLET <hidden>
Date: 2022-07-31 19:39:59

Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
boilerplate/reference with SPDX - rule 152").
An empty comment block can be removed.

While at it remove, also remove what is supposed to be the path/filename of
the file.
This is really low value... and wrong since commit 471d17148c8b
("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")

Signed-off-by: Christophe JAILLET <redacted>
---
 drivers/hid/wacom_sys.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 194a2e327591..21612fdae9c3 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1,13 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- * drivers/input/tablet/wacom_sys.c
- *
  *  USB Wacom tablet support - system specific code
  */
 
-/*
- */
-
 #include "wacom_wac.h"
 #include "wacom.h"
 #include <linux/input/mt.h>
-- 
2.34.1

Re: [PATCH] HID: wacom: Simplify comments

From: Jason Gerecke <hidden>
Date: 2022-08-02 15:38:25

On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
[off-list ref] wrote:
quoted hunk
Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
boilerplate/reference with SPDX - rule 152").
An empty comment block can be removed.

While at it remove, also remove what is supposed to be the path/filename of
the file.
This is really low value... and wrong since commit 471d17148c8b
("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")

Signed-off-by: Christophe JAILLET <redacted>
---
 drivers/hid/wacom_sys.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 194a2e327591..21612fdae9c3 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1,13 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- * drivers/input/tablet/wacom_sys.c
- *
  *  USB Wacom tablet support - system specific code
  */

-/*
- */
-
 #include "wacom_wac.h"
 #include "wacom.h"
 #include <linux/input/mt.h>
--
2.34.1
LGTM.
Reviewed-by: Jason Gerecke <jason.gerecke@wacom.com>

Re: [PATCH] HID: wacom: Simplify comments

From: Ping Cheng <hidden>
Date: 2022-08-02 18:41:34

Hi Christophe,

Thank you for cleaning up the driver code.

On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
[off-list ref] wrote:
Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
boilerplate/reference with SPDX - rule 152").
An empty comment block can be removed.
While you are here, can you update your patch to include the removal
of the empty comment blocks and paths in the other three files:
wacom.h, wacom_wac.h, and wacom_wac.c?

Thanks,
Ping
quoted hunk
While at it remove, also remove what is supposed to be the path/filename of
the file.
This is really low value... and wrong since commit 471d17148c8b
("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")

Signed-off-by: Christophe JAILLET <redacted>
---
 drivers/hid/wacom_sys.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 194a2e327591..21612fdae9c3 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1,13 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- * drivers/input/tablet/wacom_sys.c
- *
  *  USB Wacom tablet support - system specific code
  */

-/*
- */
-
 #include "wacom_wac.h"
 #include "wacom.h"
 #include <linux/input/mt.h>
--
2.34.1

Re: [PATCH] HID: wacom: Simplify comments

From: Christophe JAILLET <hidden>
Date: 2022-08-02 18:47:54

Le 02/08/2022 à 20:41, Ping Cheng a écrit :
Hi Christophe,

Thank you for cleaning up the driver code.

On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
[off-list ref] wrote:
quoted
Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
boilerplate/reference with SPDX - rule 152").
An empty comment block can be removed.
While you are here, can you update your patch to include the removal
of the empty comment blocks and paths in the other three files:
wacom.h, wacom_wac.h, and wacom_wac.c?
I'll send a v2.
Thanks for pointing it out.

CJ

Thanks,
Ping
quoted
While at it remove, also remove what is supposed to be the path/filename of
the file.
This is really low value... and wrong since commit 471d17148c8b
("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")

Signed-off-by: Christophe JAILLET <redacted>
---
  drivers/hid/wacom_sys.c | 5 -----
  1 file changed, 5 deletions(-)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 194a2e327591..21612fdae9c3 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1,13 +1,8 @@
  // SPDX-License-Identifier: GPL-2.0-or-later
  /*
- * drivers/input/tablet/wacom_sys.c
- *
   *  USB Wacom tablet support - system specific code
   */

-/*
- */
-
  #include "wacom_wac.h"
  #include "wacom.h"
  #include <linux/input/mt.h>
--
2.34.1

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help