Re: [PATCH] Input: gpio-keys: Avoid clearing twice some memory
From: Paul Cercueil <paul@crapouillou.net>
Date: 2022-01-03 11:26:57
Also in:
kernel-janitors, lkml
Hi, Le mer., déc. 29 2021 at 22:26:56 +0100, Christophe JAILLET [off-list ref] a écrit :
bitmap_parselist() already clears the 'bits' bitmap, so there is no need to clear it when it is allocated. This just wastes some cycles. Signed-off-by: Christophe JAILLET <redacted>
Acked-by: Paul Cercueil <paul@crapouillou.net> Cheers, -Paul
quoted hunk ↗ jump to hunk
--- drivers/input/keyboard/gpio_keys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/keyboard/gpio_keys.cb/drivers/input/keyboard/gpio_keys.c index 8dbf1e69c90a..d75a8b179a8a 100644--- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c@@ -247,7 +247,7 @@ static ssize_t gpio_keys_attr_store_helper(structgpio_keys_drvdata *ddata, ssize_t error; int i; - bits = bitmap_zalloc(n_events, GFP_KERNEL); + bits = bitmap_alloc(n_events, GFP_KERNEL); if (!bits) return -ENOMEM; -- 2.32.0