# Re: Input: xpad - add more Xbox one controller IDs

- From: Benjamin Valentin \<benpicco@googlemail.com\>
- Date: 2021-11-16 15:53:46 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2021/11/8933583
- Thread: https://ratatoskr.run/linux-input/2021/11/8933570/t.md

```text
On Sun, 14 Nov 2021 15:14:38 -0600
Cameron Gutman [ref] wrote:

> I like this idea. There's a small risk of causing userspace breakages
> for games matching "Generic X-Box pad" by name, but we already run
> that risk each time we update xpad_devices[] anyway.

Since the button mappings already differ between the original Xbox
controller and the Xbox 360 controller, matching that string would have
always been broken.

> Can you also replace "Generic X-Box pad" with NULL in xpad_devices[]?
> I don't think it would ever be used anymore after this change.

Will do!

Best,
Benjamin
```