# \[PATCH\] HID: nintendo: unlock on error in joycon\_leds\_create()

- Subsystems: HID CORE LAYER, NINTENDO HID DRIVER, THE REST
- Maintainers: Jiri Kosina, Benjamin Tissoires, Daniel J. Ogorchock, Vicki Pfau, Linus Torvalds
- List: linux-input
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-input/2021/11/8933565/t

## \[PATCH\] HID: nintendo: unlock on error in joycon\_leds\_create()

- From: Dan Carpenter \<hidden\>
- Date: 2021-11-10 08:12:28 
- Message: https://ratatoskr.run/linux-input/2021/11/8933565.md

```text
These two error paths need to drop the lock before returning.

Fixes: c5e626769563 ("HID: nintendo: add player led support")
Signed-off-by: Dan Carpenter <redacted>
---
 drivers/hid/hid-nintendo.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
index a1e0f6849875..7e1d1127493e 100644
--- a/drivers/hid/hid-nintendo.c
+++ b/drivers/hid/hid-nintendo.c
@@ -1850,8 +1850,10 @@ static int joycon_leds_create(struct joycon_ctlr *ctlr)
 				      d_name,
 				      "green",
 				      joycon_player_led_names[i]);
-		if (!name)
+		if (!name) {
+			mutex_unlock(&joycon_input_num_mutex);
 			return -ENOMEM;
+		}
 
 		led = &ctlr->leds[i];
 		led->name = name;
@@ -1864,6 +1866,7 @@ static int joycon_leds_create(struct joycon_ctlr *ctlr)
 		ret = devm_led_classdev_register(&hdev->dev, led);
 		if (ret) {
 			hid_err(hdev, "Failed registering %s LED\n", led->name);
+			mutex_unlock(&joycon_input_num_mutex);
 			return ret;
 		}
 	}
-- 
2.20.1

```

## Re: \[PATCH\] HID: nintendo: unlock on error in joycon\_leds\_create()

- From: Jiri Kosina \<jikos@kernel.org\>
- Date: 2021-11-10 09:02:49 
- Message: https://ratatoskr.run/linux-input/2021/11/8933566.md

```text
On Wed, 10 Nov 2021, Dan Carpenter wrote:

> These two error paths need to drop the lock before returning.
> 
> Fixes: c5e626769563 ("HID: nintendo: add player led support")
> Signed-off-by: Dan Carpenter <redacted>

Thanks for spotting it; applied.

-- 
Jiri Kosina
SUSE Labs

```