# Re: \[PATCH\] input\&tty: Fix the keyboard led light display problem

- From: Jiri Slaby \<jirislaby@kernel.org\>
- Date: 2021-10-14 14:55:37 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2021/10/1542023
- Thread: https://ratatoskr.run/linux-input/2021/10/1541835/t.md

```text
On 14. 10. 21, 17:13, Andy Shevchenko wrote:
> On Thu, Oct 14, 2021 at 03:16:27PM +0800, lianzhi chang wrote:
>> Switching from the desktop environment to the tty environment,
>> the state of the keyboard led lights and the state of the keyboard
>> lock are inconsistent. This is because the attribute kb->kbdmode
>> of the tty bound in the desktop environment (xorg) is set to
>> VC_OFF, which causes the ledstate and kb->ledflagstate
>> values of the bound tty to always be 0, which causes the switch
>> from the desktop When to the tty environment, the LED light
>> status is inconsistent with the keyboard lock status.
>
> ...
>
>> +void update_value_ledstate(unsigned int flag, unsigned int value)
>> +{
>> +	unsigned int bit;
>
> unsigned long bit;
>
> (see below why)

You'd need ledstate to be ulong, not bit. Or am I missing something?

-- 
js
```