RE: [PATCH] AMD_SFH: Fix potential NULL pointer dereference
From: Shah, Nehal-bakulchandra <hidden>
Date: 2021-09-15 17:32:19
Also in:
lkml
From: Shah, Nehal-bakulchandra <hidden>
Date: 2021-09-15 17:32:19
Also in:
lkml
Adding Basavaraj -----Original Message----- From: Jiri Kosina <jikos@kernel.org> Sent: Wednesday, September 15, 2021 8:28 PM To: Evgeny Novikov <redacted> Cc: Shah, Nehal-bakulchandra <redacted>; Sandeep Singh <redacted>; Benjamin Tissoires <redacted>; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; ldv-project@linuxtesting.org Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference On Tue, 1 Jun 2021, Evgeny Novikov wrote:
devm_add_action_or_reset() can suddenly invoke amd_mp2_pci_remove() at registration that will cause NULL pointer dereference since corresponding data is not initialized yet. The patch moves initialization of data before devm_add_action_or_reset(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov <redacted>
Nehal, Basavaraj, could you please Review/Ack this one? Thanks, -- Jiri Kosina SUSE Labs