[PATCH] Input: adp5589-keys - Use the right header

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE1862d LANDED

Landed in mainline as 1c6aacecea38 on 2021-08-30.

3 messages, 3 authors, 2021-08-30 · open the first message on its own page

[PATCH] Input: adp5589-keys - Use the right header

From: Linus Walleij <hidden>
Date: 2021-08-16 23:29:12

This keyboard driver is implementing a GPIO driver, so it need
to include <linux/gpio/driver.h> and not the legacy <linux/gpio.h>
header.

Cc: Michael Hennerich <michael.hennerich@analog.com>
Cc: Alexandru Ardelean <redacted>
Signed-off-by: Linus Walleij <redacted>
---
 drivers/input/keyboard/adp5589-keys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/adp5589-keys.c b/drivers/input/keyboard/adp5589-keys.c
index 654e0476406b..bdd264459a97 100644
--- a/drivers/input/keyboard/adp5589-keys.c
+++ b/drivers/input/keyboard/adp5589-keys.c
@@ -18,7 +18,7 @@
 #include <linux/platform_device.h>
 #include <linux/input.h>
 #include <linux/i2c.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
 #include <linux/slab.h>
 
 #include <linux/input/adp5589.h>
-- 
2.31.1

RE: [PATCH] Input: adp5589-keys - Use the right header

From: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Date: 2021-08-17 05:56:25

-----Original Message-----
From: Linus Walleij <redacted>
Sent: Dienstag, 17. August 2021 01:27
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>; linux-
input@vger.kernel.org
Cc: Linus Walleij <redacted>; Hennerich, Michael
[off-list ref]; Alexandru Ardelean
[off-list ref]
Subject: [PATCH] Input: adp5589-keys - Use the right header
 
This keyboard driver is implementing a GPIO driver, so it need to include
<linux/gpio/driver.h> and not the legacy <linux/gpio.h> header.

Cc: Michael Hennerich <michael.hennerich@analog.com>
Cc: Alexandru Ardelean <redacted>
Signed-off-by: Linus Walleij <redacted>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
quoted hunk
---
 drivers/input/keyboard/adp5589-keys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/adp5589-keys.c
b/drivers/input/keyboard/adp5589-keys.c
index 654e0476406b..bdd264459a97 100644
--- a/drivers/input/keyboard/adp5589-keys.c
+++ b/drivers/input/keyboard/adp5589-keys.c
@@ -18,7 +18,7 @@
 #include <linux/platform_device.h>
 #include <linux/input.h>
 #include <linux/i2c.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
 #include <linux/slab.h>

 #include <linux/input/adp5589.h>
--
2.31.1

Re: [PATCH] Input: adp5589-keys - Use the right header

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-08-30 21:23:26

On Tue, Aug 17, 2021 at 01:27:07AM +0200, Linus Walleij wrote:
This keyboard driver is implementing a GPIO driver, so it need
to include <linux/gpio/driver.h> and not the legacy <linux/gpio.h>
header.

Cc: Michael Hennerich <michael.hennerich@analog.com>
Cc: Alexandru Ardelean <redacted>
Signed-off-by: Linus Walleij <redacted>
Applied, thank you.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help