# Re: \[PATCH v4 5/5\] bus: Make remove callback return void

- From: Dmitry Torokhov \<dmitry.torokhov@gmail.com\>
- Date: 2021-07-14 19:11:05 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2021/07/1444453
- Thread: https://ratatoskr.run/linux-input/2021/07/1443329/t.md

```text
On Tue, Jul 13, 2021 at 09:35:22PM +0200, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
> 
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
> 
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
> 

...

>  drivers/input/gameport/gameport.c         | 3 +--
>  drivers/input/serio/serio.c               | 3 +--

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks.

-- 
Dmitry
```
