# Re: \[PATCH 0/3\] Add SFH sensor support for newer AMD platforms

- List: linux-input
- 3 messages, 3 authors
- Page: https://ratatoskr.run/linux-input/2021/06/8933166/t

## Re: \[PATCH 0/3\] Add SFH sensor support for newer AMD platforms

- From: Dylan MacKenzie \<hidden\>
- Date: 2021-06-26 23:34:35 
- Message: https://ratatoskr.run/linux-input/2021/06/8933166.md

```text
> Now queued in for-5.14/amd-sfh. Thanks,

FYI, this patch still uses the wrong register in `amd_sensor_stop_v2`.
Basavaraj confirmed this, but my email client didn't CC the list for
that conversation. Whoops!

Also, I've tested this locally on an HP Envy x360 with a Ryzen 4700U
(Renoir) and it doesn't work even though the new code paths are taken.
My `activecontrolstatus`, the register containing the sensor mask
along with the newly checked hardware ID in the lower four bits, is
`0x002bdff2`. Just like before, three IIO devices are initialized, but
the first read from the DMA buffers returns a constant, garbage value,
and all subsequent reads return zeroes. I assume that this patch is
working on whatever hardware the OP is using to test. Should it be
working on all Renoir systems?
```

## Re: \[PATCH 0/3\] Add SFH sensor support for newer AMD platforms

- From: Jiri Kosina \<jikos@kernel.org\>
- Date: 2021-07-12 08:10:23 
- Message: https://ratatoskr.run/linux-input/2021/07/8933177.md

```text
On Sat, 26 Jun 2021, Dylan MacKenzie wrote:

> > Now queued in for-5.14/amd-sfh. Thanks,
> 
> FYI, this patch still uses the wrong register in `amd_sensor_stop_v2`.
> Basavaraj confirmed this, but my email client didn't CC the list for
> that conversation. Whoops!

Could you please send a followup patch on top of for-5.14/amd-sfh branch 
to fix that?

Thanks,

-- 
Jiri Kosina
SUSE Labs

```

## Re: \[PATCH 0/3\] Add SFH sensor support for newer AMD platforms

- From: Basavaraj Natikar \<hidden\>
- Date: 2021-07-15 06:39:08 
- Message: https://ratatoskr.run/linux-input/2021/07/8933183.md

```text
hi Jiri

On 7/12/2021 1:38 PM, Jiri Kosina wrote:
> [CAUTION: External Email]
>
> On Sat, 26 Jun 2021, Dylan MacKenzie wrote:
>
>>> Now queued in for-5.14/amd-sfh. Thanks,
>> FYI, this patch still uses the wrong register in `amd_sensor_stop_v2`.
>> Basavaraj confirmed this, but my email client didn't CC the list for
>> that conversation. Whoops!
> Could you please send a followup patch on top of for-5.14/amd-sfh branch
> to fix that?

I see that, Dylan MacKenzie has already sent a followup patch.

Thanks,
Basavaraj

```