# Re: \[PATCH 0/3\] Add SFH sensor support for newer AMD platforms

- From: Dylan MacKenzie \<hidden\>
- Date: 2021-06-26 23:34:35 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2021/06/8933166
- Thread: https://ratatoskr.run/linux-input/2021/06/8933166/t.md

```text
> Now queued in for-5.14/amd-sfh. Thanks,

FYI, this patch still uses the wrong register in `amd_sensor_stop_v2`.
Basavaraj confirmed this, but my email client didn't CC the list for
that conversation. Whoops!

Also, I've tested this locally on an HP Envy x360 with a Ryzen 4700U
(Renoir) and it doesn't work even though the new code paths are taken.
My `activecontrolstatus`, the register containing the sensor mask
along with the newly checked hardware ID in the lower four bits, is
`0x002bdff2`. Just like before, three IIO devices are initialized, but
the first read from the DMA buffers returns a constant, garbage value,
and all subsequent reads return zeroes. I assume that this patch is
working on whatever hardware the OP is using to test. Should it be
working on all Renoir systems?
```