# \[PATCH -next\] Input: ims-pcu - Fix kobj\_to\_dev.cocci warnings

- Subsystems: INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN) DRIVERS, THE REST
- Maintainers: Dmitry Torokhov, Linus Torvalds
- Status: LANDED (f519f78c7e95 · 2021-06-20 05:36)
- Landed in mainline as f519f78c7e95 on 2021-06-20.
- List: linux-input
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-input/2021/06/1404811/t

## \[PATCH -next\] Input: ims-pcu - Fix kobj\_to\_dev.cocci warnings

- From: YueHaibing \<hidden\>
- Date: 2021-06-07 12:25:39 
- Message: https://ratatoskr.run/linux-input/2021/06/1404811.md

```text
Use kobj_to_dev() instead of container_of()

Generated by: scripts/coccinelle/api/kobj_to_dev.cocci

Signed-off-by: YueHaibing <redacted>
---
 drivers/input/misc/ims-pcu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
index 7169255efb37..6f38aa23a1ff 100644
--- a/drivers/input/misc/ims-pcu.c
+++ b/drivers/input/misc/ims-pcu.c
@@ -1228,7 +1228,7 @@ static struct attribute *ims_pcu_attrs[] = {
 static umode_t ims_pcu_is_attr_visible(struct kobject *kobj,
 				       struct attribute *attr, int n)
 {
-	struct device *dev = container_of(kobj, struct device, kobj);
+	struct device *dev = kobj_to_dev(kobj);
 	struct usb_interface *intf = to_usb_interface(dev);
 	struct ims_pcu *pcu = usb_get_intfdata(intf);
 	umode_t mode = attr->mode;
-- 
2.17.1

```

## Re: \[PATCH -next\] Input: ims-pcu - Fix kobj\_to\_dev.cocci warnings

- From: Dmitry Torokhov \<dmitry.torokhov@gmail.com\>
- Date: 2021-06-20 05:24:09 
- Message: https://ratatoskr.run/linux-input/2021/06/1420097.md

```text
On Mon, Jun 07, 2021 at 08:25:33PM +0800, YueHaibing wrote:
> Use kobj_to_dev() instead of container_of()
> 
> Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
> 
> Signed-off-by: YueHaibing <redacted>

Applied, thank you.

-- 
Dmitry
```
