# Re: \[PATCH 1/3\] HID: asus: Cleanup Asus T101HA keyboard-dock handling

- From: Benjamin Tissoires \<hidden\>
- Date: 2021-05-05 13:36:20 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2021/05/8932968
- Thread: https://ratatoskr.run/linux-input/2021/03/8932731/t.md

```text
On Wed, May 5, 2021 at 2:24 PM Jiri Kosina [ref] wrote:
>
> On Wed, 31 Mar 2021, Jiri Kosina wrote:
>
> > > There is no need to use a quirk and then return -ENODEV from the
> > > asus_probe() function to avoid that hid-asus binds to the hiddev
> > > for the USB-interface for the hid-multitouch touchpad.
> > >
> > > The hid-multitouch hiddev has a group of HID_GROUP_MULTITOUCH_WIN_8,
> > > so the same result can be achieved by making the hid_device_id entry
> > > for the dock in the asus_devices[] table only match on HID_GROUP_GENERIC
> > > instead of having it match HID_GROUP_ANY.
> >
> > Benjamin, could you please Ack this series, as it touches hid-multitouch,
> > please?
>
> Benjamin, friendly ping on this one.
>

Sorry for being such a bad co-maintainer... :(

This one completely fell through the cracks.

I have no objections for 1/3 and 2/3. I'll comment on 3/3.

Cheers,
Benjamin

```