# \[PATCH v2 1/2\] Input: resistive-adc-touch - describe parameters in kernel doc - Subsystems: GENERIC RESISTIVE TOUCHSCREEN ADC DRIVER, INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN) DRIVERS, THE REST - Maintainers: Eugen Hristev, Dmitry Torokhov, Linus Torvalds - Status: LANDED (02e28cf7dc2b ยท 2021-06-01 05:52) - Landed in mainline as 02e28cf7dc2b on 2021-06-01. - List: linux-input - 4 messages, 2 authors - Page: https://ratatoskr.run/linux-input/2021/05/1395306/t ## \[PATCH v2 1/2\] Input: resistive-adc-touch - describe parameters in kernel doc - From: Andy Shevchenko \ - Date: 2021-05-28 15:11:02 - Message: https://ratatoskr.run/linux-input/2021/05/1395306.md ```text Validation script is not happy: resistive-adc-touch.c:53: warning: Function parameter or member 'x_plate_ohms' not described in 'grts_state' resistive-adc-touch.c:53: warning: Function parameter or member 'ch' not described in 'grts_state' Describe parameters in kernel doc to make it happy. Fixes: fb082cd59afa ("Input: resistive-adc-touch - add support for z1 and z2 channels") Signed-off-by: Andy Shevchenko --- drivers/input/touchscreen/resistive-adc-touch.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/resistive-adc-touch.c b/drivers/input/touchscreen/resistive-adc-touch.c index 0939c0e97efb..0353400c559a 100644 --- a/drivers/input/touchscreen/resistive-adc-touch.c +++ b/drivers/input/touchscreen/resistive-adc-touch.c @@ -35,16 +35,18 @@ enum grts_ch_type { /** * struct grts_state - generic resistive touch screen information struct + * @x_plate_ohms: resistance of the X plate * @pressure_min: number representing the minimum for the pressure * @pressure: are we getting pressure info or not * @iio_chans: list of channels acquired * @iio_cb: iio_callback buffer for the data * @input: the input device structure that we register * @prop: touchscreen properties struct + * @ch: channels that are defined for the touchscreen */ struct grts_state { - u32 pressure_min; u32 x_plate_ohms; + u32 pressure_min; bool pressure; struct iio_channel *iio_chans; struct iio_cb_buffer *iio_cb; -- 2.30.2 ``` ## \[PATCH v2 2/2\] Input: resistive-adc-touch - replace OF headers with proper ones - From: Andy Shevchenko \ - Date: 2021-05-28 15:11:01 - Message: https://ratatoskr.run/linux-input/2021/05/1395305.md ```text The driver is actually OF independent and doesn't need anything from OF (*). Replace OF headers with mod_devicetable.h and property.h. *) use of of_match_ptr() is actually wrong here, since it may provoke a compiler to warn about unused variable. Signed-off-by: Andy Shevchenko --- drivers/input/touchscreen/resistive-adc-touch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/resistive-adc-touch.c b/drivers/input/touchscreen/resistive-adc-touch.c index 0353400c559a..ea1884fb49a1 100644 --- a/drivers/input/touchscreen/resistive-adc-touch.c +++ b/drivers/input/touchscreen/resistive-adc-touch.c @@ -13,10 +13,10 @@ #include #include #include +#include #include -#include -#include #include +#include #define DRIVER_NAME "resistive-adc-touch" #define GRTS_DEFAULT_PRESSURE_MIN 50000 @@ -307,7 +307,7 @@ static struct platform_driver grts_driver = { .probe = grts_probe, .driver = { .name = DRIVER_NAME, - .of_match_table = of_match_ptr(grts_of_match), + .of_match_table = grts_of_match, }, }; -- 2.30.2 ``` ## Re: \[PATCH v2 1/2\] Input: resistive-adc-touch - describe parameters in kernel doc - From: Dmitry Torokhov \ - Date: 2021-06-01 05:53:13 - Message: https://ratatoskr.run/linux-input/2021/06/1398117.md ```text On Fri, May 28, 2021 at 06:11:12PM +0300, Andy Shevchenko wrote: > Validation script is not happy: > > resistive-adc-touch.c:53: warning: Function parameter or member 'x_plate_ohms' not described in 'grts_state' > resistive-adc-touch.c:53: warning: Function parameter or member 'ch' not described in 'grts_state' > > Describe parameters in kernel doc to make it happy. > > Fixes: fb082cd59afa ("Input: resistive-adc-touch - add support for z1 and z2 channels") > Signed-off-by: Andy Shevchenko Applied, thank you. -- Dmitry ``` ## Re: \[PATCH v2 2/2\] Input: resistive-adc-touch - replace OF headers with proper ones - From: Dmitry Torokhov \ - Date: 2021-06-01 05:53:40 - Message: https://ratatoskr.run/linux-input/2021/06/1398118.md ```text On Fri, May 28, 2021 at 06:11:13PM +0300, Andy Shevchenko wrote: > The driver is actually OF independent and doesn't need anything from OF (*). > Replace OF headers with mod_devicetable.h and property.h. > > *) use of of_match_ptr() is actually wrong here, since it may provoke > a compiler to warn about unused variable. > > Signed-off-by: Andy Shevchenko Applied, thank you. -- Dmitry ```