# \[PATCH\] Input: cyttsp - do not force interrupt trigger - Subsystems: CYTTSP TOUCHSCREEN DRIVER, INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN) DRIVERS, THE REST - Maintainers: Linus Walleij, Dmitry Torokhov, Linus Torvalds - Status: LANDED (c9d2939dda3b ยท 2021-05-31 04:54) - Landed in mainline as c9d2939dda3b on 2021-05-31. - List: linux-input - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-input/2021/05/1393296/t ## \[PATCH\] Input: cyttsp - do not force interrupt trigger - From: Dmitry Torokhov \ - Date: 2021-05-27 00:07:13 - Message: https://ratatoskr.run/linux-input/2021/05/1393296.md ```text Instead of forcing interrupt trigger to be "falling edge" let's rely on the platform to set it up according to how it is set up on a given board based on data in device tree or ACPI tables. Signed-off-by: Dmitry Torokhov --- Linus, Ferruh's email has been bouncing for ages, it looks like you have the hardware and you are already looking over another Cypress touch controller, mind if I put you down as a maintainer for this one as well? drivers/input/touchscreen/cyttsp_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c index d9debcdeeec7..a6352d79e23d 100644 --- a/drivers/input/touchscreen/cyttsp_core.c +++ b/drivers/input/touchscreen/cyttsp_core.c @@ -699,8 +699,7 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops, } error = devm_request_threaded_irq(dev, ts->irq, NULL, cyttsp_irq, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT | - IRQF_NO_AUTOEN, + IRQF_ONESHOT | IRQF_NO_AUTOEN, "cyttsp", ts); if (error) { dev_err(ts->dev, "failed to request IRQ %d, err: %d\n", -- 2.31.1.818.g46aad6cb9e-goog -- Dmitry ``` ## Re: \[PATCH\] Input: cyttsp - do not force interrupt trigger - From: Linus Walleij \ - Date: 2021-05-27 00:30:37 - Message: https://ratatoskr.run/linux-input/2021/05/1393312.md ```text On Thu, May 27, 2021 at 2:05 AM Dmitry Torokhov [ref] wrote: > Instead of forcing interrupt trigger to be "falling edge" let's rely on the > platform to set it up according to how it is set up on a given board based > on data in device tree or ACPI tables. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Linus Walleij > Linus, Ferruh's email has been bouncing for ages, it looks like you have > the hardware and you are already looking over another Cypress touch > controller, mind if I put you down as a maintainer for this one as well? That's fine, just list me if you want, one more or less. Yours, Linus Walleij ```