# Re: \[PATCH\] HID: magicmouse: fix NULL-deref on disconnect

- From: Jiri Kosina \<jikos@kernel.org\>
- Date: 2021-05-26 10:51:15 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2021/05/1392504
- Thread: https://ratatoskr.run/linux-input/2021/05/1379411/t.md

```text
On Mon, 17 May 2021, Johan Hovold wrote:

> Commit 9d7b18668956 ("HID: magicmouse: add support for Apple Magic
> Trackpad 2") added a sanity check for an Apple trackpad but returned
> success instead of -ENODEV when the check failed. This means that the
> remove callback will dereference the never-initialised driver data
> pointer when the driver is later unbound (e.g. on USB disconnect).
> 
> Reported-by: <redacted>
> Fixes: 9d7b18668956 ("HID: magicmouse: add support for Apple Magic Trackpad 2")
> Cc: <redacted>      # 4.20
> Cc: Claudio Mettler <redacted>
> Cc: Marek Wyborski <redacted>
> Cc: Sean O'Brien <redacted>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Applied, thanks Johan.

-- 
Jiri Kosina
SUSE Labs

```