# Re: \[PATCH\] HID: hiddev: Return specific error codes on connect failure

- From: Jiri Kosina \<jikos@kernel.org\>
- Date: 2021-03-08 10:14:19 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2021/03/8932745
- Thread: https://ratatoskr.run/linux-input/2021/02/8932569/t.md

```text
On Thu, 11 Feb 2021, Jason Gerecke wrote:

> The only caller of this function only cares about gross success/failure
> but we still might as well resolve the following smatch warning and fix
> the other error paths as well:
> 
>     hiddev.c:894 hiddev_connect() warn: returning -1 instead of -ENOMEM is sloppy
> 
> Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>

Applied, thank you Jason.

-- 
Jiri Kosina
SUSE Labs

```