[PATCH] Input: ims-pcu - drop redundant driver-data assignment

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE1969d LANDED

Landed in mainline as bfae2779fe4b on 2021-03-20.

2 messages, 2 authors, 2021-03-20 · open the first message on its own page

[PATCH] Input: ims-pcu - drop redundant driver-data assignment

From: Johan Hovold <johan@kernel.org>
Date: 2021-03-18 15:56:05

The driver data for the data interface has already been set by
usb_driver_claim_interface() so drop the subsequent redundant
assignment.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/input/misc/ims-pcu.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
index 08b9b5cdb943..81de8c4e37d0 100644
--- a/drivers/input/misc/ims-pcu.c
+++ b/drivers/input/misc/ims-pcu.c
@@ -2018,7 +2018,6 @@ static int ims_pcu_probe(struct usb_interface *intf,
 	}
 
 	usb_set_intfdata(pcu->ctrl_intf, pcu);
-	usb_set_intfdata(pcu->data_intf, pcu);
 
 	error = ims_pcu_buffers_alloc(pcu);
 	if (error)
-- 
2.26.2

Re: [PATCH] Input: ims-pcu - drop redundant driver-data assignment

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-03-20 03:39:32

On Thu, Mar 18, 2021 at 04:55:25PM +0100, Johan Hovold wrote:
The driver data for the data interface has already been set by
usb_driver_claim_interface() so drop the subsequent redundant
assignment.

Signed-off-by: Johan Hovold <johan@kernel.org>
Applied, thank you.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help