Re: [PATCH] Input: st1232 - Fix NORMAL vs. IDLE state handling
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-02-23 17:31:36
Also in:
linux-renesas-soc, lkml
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-02-23 17:31:36
Also in:
linux-renesas-soc, lkml
On Tue, Feb 23, 2021 at 11:29:00AM +0100, Michael Tretter wrote:
On Tue, 23 Feb 2021 10:02:01 +0100, Geert Uytterhoeven wrote:quoted
NORMAL (0x0) and IDLE (0x4) are really two different states. Hence you cannot check for both using a bitmask, as that checks for IDLE only, breaking operation for devices that are in NORMAL state.Thanks. I missed that the state is actually a value and not a bitfield.quoted
Fix the wait function to report either state as ready. Fixes: 6524d8eac258452e ("Input: st1232 - add IDLE state as ready condition") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Applied, thank you. -- Dmitry