# \[PATCH\] Input: fix boolreturn.cocci warnings

- List: linux-input
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-input/2021/02/6272845/t

## \[PATCH\] Input: fix boolreturn.cocci warnings

- From: kernel test robot \<hidden\>
- Date: 2021-02-18 11:30:54 
- Message: https://ratatoskr.run/linux-input/2021/02/6272845.md

```text
From: kernel test robot <redacted>

drivers/input/touchscreen/zinitix.c:250:8-9: WARNING: return of 0/1 in function 'zinitix_init_touch' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 26822652c85e ("Input: add zinitix touchscreen driver")
CC: Michael Srba <redacted>
Reported-by: kernel test robot <redacted>
Signed-off-by: kernel test robot <redacted>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   f40ddce88593482919761f74910f42f4b84c004b
commit: 26822652c85eff14e40115255727b2693400c524 Input: add zinitix touchscreen driver

 zinitix.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/input/touchscreen/zinitix.c
+++ b/drivers/input/touchscreen/zinitix.c
@@ -247,7 +247,7 @@ static bool zinitix_init_touch(struct bt
 		udelay(10);
 	}
 
-	return 0;
+	return false;
 }
 
 static int zinitix_init_regulators(struct bt541_ts_data *bt541)
```

## Re: \[PATCH\] Input: fix boolreturn.cocci warnings

- From: Dmitry Torokhov \<dmitry.torokhov@gmail.com\>
- Date: 2021-02-19 03:36:59 
- Message: https://ratatoskr.run/linux-input/2021/02/6273552.md

```text
Hi,

On Thu, Feb 18, 2021 at 05:59:53PM +0800, kernel test robot wrote:
> From: kernel test robot <redacted>
> 
> drivers/input/touchscreen/zinitix.c:250:8-9: WARNING: return of 0/1 in function 'zinitix_init_touch' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: 26822652c85e ("Input: add zinitix touchscreen driver")
> CC: Michael Srba <redacted>
> Reported-by: kernel test robot <redacted>
> Signed-off-by: kernel test robot <redacted>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   f40ddce88593482919761f74910f42f4b84c004b
> commit: 26822652c85eff14e40115255727b2693400c524 Input: add zinitix touchscreen driver
> 
>  zinitix.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/input/touchscreen/zinitix.c
> +++ b/drivers/input/touchscreen/zinitix.c
> @@ -247,7 +247,7 @@ static bool zinitix_init_touch(struct bt
>  		udelay(10);
>  	}
>  
> -	return 0;
> +	return false;

This is incorrect as function is trying to return error codes. It needs
to be changed to return int. I'll take care of it.

Thanks.

-- 
Dmitry
```