# \[PATCH RFC\] input/elants\_i2c: Detect enum overflow - Subsystems: INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN) DRIVERS, THE REST - Maintainers: Dmitry Torokhov, Linus Torvalds - Status: LANDED · 1 review, 1 by a maintainer (ede6747c2f89 · 2021-02-16 21:08 M Randy Dunlap) - Landed in mainline as ede6747c2f89 on 2021-02-16. - 1 review trailer. - List: linux-input - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-input/2021/02/6266080/t ## \[PATCH RFC\] input/elants\_i2c: Detect enum overflow - From: Josh Poimboeuf \ - Date: 2021-02-10 16:28:19 - Message: https://ratatoskr.run/linux-input/2021/02/6266080.md ```text If an enum value were to get added without updating this switch statement, the unreachable() annotation would trigger undefined behavior, causing execution to fall through the end of the function, into the next one. Make the error handling more robust for an unexpected enum value, by doing BUG() instead of unreachable(). Fixes the following objtool warning: drivers/input/touchscreen/elants_i2c.o: warning: objtool: elants_i2c_initialize() falls through to next function elants_i2c_resume() Reported-by: Randy Dunlap Acked-by: Randy Dunlap Signed-off-by: Josh Poimboeuf --- drivers/input/touchscreen/elants_i2c.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index 6f57ec579f00..4c2b579f6c8b 100644 --- a/drivers/input/touchscreen/elants_i2c.c +++ b/drivers/input/touchscreen/elants_i2c.c @@ -656,8 +656,7 @@ static int elants_i2c_initialize(struct elants_data *ts) error = elants_i2c_query_ts_info_ektf(ts); break; default: - unreachable(); - break; + BUG(); } if (error) -- 2.29.2 ``` ## Re: \[PATCH RFC\] input/elants\_i2c: Detect enum overflow - From: Michał Mirosław \ - Date: 2021-02-11 02:21:16 - Message: https://ratatoskr.run/linux-input/2021/02/6266792.md ```text On Wed, Feb 10, 2021 at 10:25:28AM -0600, Josh Poimboeuf wrote: > If an enum value were to get added without updating this switch > statement, the unreachable() annotation would trigger undefined > behavior, causing execution to fall through the end of the function, > into the next one. > > Make the error handling more robust for an unexpected enum value, by > doing BUG() instead of unreachable(). > > Fixes the following objtool warning: > > drivers/input/touchscreen/elants_i2c.o: warning: objtool: elants_i2c_initialize() falls through to next function elants_i2c_resume() > > Reported-by: Randy Dunlap > Acked-by: Randy Dunlap > Signed-off-by: Josh Poimboeuf Reviewed-by: Michał Mirosław > --- > drivers/input/touchscreen/elants_i2c.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c > index 6f57ec579f00..4c2b579f6c8b 100644 > --- a/drivers/input/touchscreen/elants_i2c.c > +++ b/drivers/input/touchscreen/elants_i2c.c > @@ -656,8 +656,7 @@ static int elants_i2c_initialize(struct elants_data *ts) > error = elants_i2c_query_ts_info_ektf(ts); > break; > default: > - unreachable(); > - break; > + BUG(); > } > > if (error) > -- > 2.29.2 > ```