# \[PATCH\] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID - Subsystems: HID CORE LAYER, INTEL INTEGRATED SENSOR HUB DRIVER, THE REST - Maintainers: Jiri Kosina, Benjamin Tissoires, Srinivas Pandruvada, Linus Torvalds - List: linux-input - 5 messages, 3 authors - Page: https://ratatoskr.run/linux-input/2021/02/6258215/t ## \[PATCH\] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID - From: You-Sheng Yang \ - Date: 2021-02-04 08:34:09 - Message: https://ratatoskr.run/linux-input/2021/02/6258215.md ```text Added Tiger Lake H PCI device ID to the supported device list. Signed-off-by: You-Sheng Yang --- drivers/hid/intel-ish-hid/ipc/hw-ish.h | 1 + drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/hid/intel-ish-hid/ipc/hw-ish.h b/drivers/hid/intel-ish-hid/ipc/hw-ish.h index 1fb294ca463e..21b0e6123754 100644 --- a/drivers/hid/intel-ish-hid/ipc/hw-ish.h +++ b/drivers/hid/intel-ish-hid/ipc/hw-ish.h @@ -27,6 +27,7 @@ #define CMP_H_DEVICE_ID 0x06FC #define EHL_Ax_DEVICE_ID 0x4BB3 #define TGL_LP_DEVICE_ID 0xA0FC +#define TGL_H_DEVICE_ID 0x43FC #define REVISION_ID_CHT_A0 0x6 #define REVISION_ID_CHT_Ax_SI 0x0 diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c index c6d48a8648b7..6dea657b7b15 100644 --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c @@ -37,6 +37,7 @@ static const struct pci_device_id ish_pci_tbl[] = { {PCI_DEVICE(PCI_VENDOR_ID_INTEL, CMP_H_DEVICE_ID)}, {PCI_DEVICE(PCI_VENDOR_ID_INTEL, EHL_Ax_DEVICE_ID)}, {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_LP_DEVICE_ID)}, + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_H_DEVICE_ID)}, {0, } }; MODULE_DEVICE_TABLE(pci, ish_pci_tbl); -- 2.29.2 ``` ## Re: \[PATCH\] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID - From: Srinivas Pandruvada \ - Date: 2021-02-04 15:16:57 - Message: https://ratatoskr.run/linux-input/2021/02/6258675.md ```text On Thu, 2021-02-04 at 16:33 +0800, You-Sheng Yang wrote: > Added Tiger Lake H PCI device ID to the supported device list. > > Signed-off-by: You-Sheng Yang Did you get chance to verify on a platform? Do you see sensors enumerated in /sys/bus/iio? Thanks, Srinivas > --- > drivers/hid/intel-ish-hid/ipc/hw-ish.h | 1 + > drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/hid/intel-ish-hid/ipc/hw-ish.h > b/drivers/hid/intel-ish-hid/ipc/hw-ish.h > index 1fb294ca463e..21b0e6123754 100644 > --- a/drivers/hid/intel-ish-hid/ipc/hw-ish.h > +++ b/drivers/hid/intel-ish-hid/ipc/hw-ish.h > @@ -27,6 +27,7 @@ > #define CMP_H_DEVICE_ID 0x06FC > #define EHL_Ax_DEVICE_ID 0x4BB3 > #define TGL_LP_DEVICE_ID 0xA0FC > +#define TGL_H_DEVICE_ID 0x43FC > > #define REVISION_ID_CHT_A0 0x6 > #define REVISION_ID_CHT_Ax_SI 0x0 > diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c > b/drivers/hid/intel-ish-hid/ipc/pci-ish.c > index c6d48a8648b7..6dea657b7b15 100644 > --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c > +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c > @@ -37,6 +37,7 @@ static const struct pci_device_id ish_pci_tbl[] = { > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, CMP_H_DEVICE_ID)}, > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, EHL_Ax_DEVICE_ID)}, > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_LP_DEVICE_ID)}, > + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_H_DEVICE_ID)}, > {0, } > }; > MODULE_DEVICE_TABLE(pci, ish_pci_tbl); ``` ## Re: \[PATCH\] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID - From: You-Sheng Yang \ - Date: 2021-02-05 03:52:50 - Message: https://ratatoskr.run/linux-input/2021/02/6259502.md ```text On 2/4/21 11:13 PM, Srinivas Pandruvada wrote: > On Thu, 2021-02-04 at 16:33 +0800, You-Sheng Yang wrote: >> Added Tiger Lake H PCI device ID to the supported device list. >> >> Signed-off-by: You-Sheng Yang > Did you get chance to verify on a platform? > Do you see sensors enumerated in /sys/bus/iio? Yes, [ 2.485650] ish-hid {33AECD58-B679-4E54-9BD9-A04D34F0C226}: [hid-ish]: enum_devices_done OK, num_hid_devices=3 [ 2.497337] hid-generic 001F:8087:0AC2.0003: hidraw2: HID v2.00 Device [hid-ishtp 8087:0AC2] on [ 2.506945] hid-generic 001F:8087:0AC2.0004: hidraw3: HID v2.00 Device [hid-ishtp 8087:0AC2] on [ 2.512127] hid-generic 001F:8087:0AC2.0005: hidraw4: HID v2.00 Device [hid-ishtp 8087:0AC2] on $ ls /sys/bus/iio/devices/ iio:device0 iio:device1 trigger0 trigger1 One of them is an ambient light sensor, and it works only with this patch applied. Thanks, You-Sheng Yang > Thanks, > Srinivas > >> --- >> drivers/hid/intel-ish-hid/ipc/hw-ish.h | 1 + >> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/hid/intel-ish-hid/ipc/hw-ish.h >> b/drivers/hid/intel-ish-hid/ipc/hw-ish.h >> index 1fb294ca463e..21b0e6123754 100644 >> --- a/drivers/hid/intel-ish-hid/ipc/hw-ish.h >> +++ b/drivers/hid/intel-ish-hid/ipc/hw-ish.h >> @@ -27,6 +27,7 @@ >> #define CMP_H_DEVICE_ID 0x06FC >> #define EHL_Ax_DEVICE_ID 0x4BB3 >> #define TGL_LP_DEVICE_ID 0xA0FC >> +#define TGL_H_DEVICE_ID 0x43FC >> >> #define REVISION_ID_CHT_A0 0x6 >> #define REVISION_ID_CHT_Ax_SI 0x0 >> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c >> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c >> index c6d48a8648b7..6dea657b7b15 100644 >> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c >> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c >> @@ -37,6 +37,7 @@ static const struct pci_device_id ish_pci_tbl[] = { >> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, CMP_H_DEVICE_ID)}, >> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, EHL_Ax_DEVICE_ID)}, >> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_LP_DEVICE_ID)}, >> + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_H_DEVICE_ID)}, >> {0, } >> }; >> MODULE_DEVICE_TABLE(pci, ish_pci_tbl); > ``` ## Re: \[PATCH\] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID - From: Srinivas Pandruvada \ - Date: 2021-02-08 18:28:25 - Message: https://ratatoskr.run/linux-input/2021/02/6263018.md ```text On Thu, 2021-02-04 at 16:33 +0800, You-Sheng Yang wrote: > Added Tiger Lake H PCI device ID to the supported device list. > > Signed-off-by: You-Sheng Yang Acked-by: Srinivas Pandruvada > --- > drivers/hid/intel-ish-hid/ipc/hw-ish.h | 1 + > drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/hid/intel-ish-hid/ipc/hw-ish.h > b/drivers/hid/intel-ish-hid/ipc/hw-ish.h > index 1fb294ca463e..21b0e6123754 100644 > --- a/drivers/hid/intel-ish-hid/ipc/hw-ish.h > +++ b/drivers/hid/intel-ish-hid/ipc/hw-ish.h > @@ -27,6 +27,7 @@ > #define CMP_H_DEVICE_ID 0x06FC > #define EHL_Ax_DEVICE_ID 0x4BB3 > #define TGL_LP_DEVICE_ID 0xA0FC > +#define TGL_H_DEVICE_ID 0x43FC > > #define REVISION_ID_CHT_A0 0x6 > #define REVISION_ID_CHT_Ax_SI 0x0 > diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c > b/drivers/hid/intel-ish-hid/ipc/pci-ish.c > index c6d48a8648b7..6dea657b7b15 100644 > --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c > +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c > @@ -37,6 +37,7 @@ static const struct pci_device_id ish_pci_tbl[] = { > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, CMP_H_DEVICE_ID)}, > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, EHL_Ax_DEVICE_ID)}, > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_LP_DEVICE_ID)}, > + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, TGL_H_DEVICE_ID)}, > {0, } > }; > MODULE_DEVICE_TABLE(pci, ish_pci_tbl); ``` ## Re: \[PATCH\] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID - From: Jiri Kosina \ - Date: 2021-02-09 09:31:12 - Message: https://ratatoskr.run/linux-input/2021/02/6264057.md ```text On Mon, 8 Feb 2021, Srinivas Pandruvada wrote: > > Added Tiger Lake H PCI device ID to the supported device list. > > > > Signed-off-by: You-Sheng Yang > Acked-by: Srinivas Pandruvada Applied, thanks. -- Jiri Kosina SUSE Labs ```