# Re: \[PATCH 04/10\] input: iqs5xx: Expose firmware revision to user space

- From: Dmitry Torokhov \<dmitry.torokhov@gmail.com\>
- Date: 2021-01-25 04:22:49 
- List: linux-input
- Page: https://ratatoskr.run/linux-input/2021/01/8932469
- Thread: https://ratatoskr.run/linux-input/2021/01/8932445/t.md

```text
Hi Jeff,

On Mon, Jan 18, 2021 at 02:43:40PM -0600, Jeff LaBundy wrote:
> The device's firmware accommodates a revision field that customers
> can assign when firmware is exported from the vendor's development
> tool. Having the ability to read this field from user space can be
> useful during development.
> 
> As such, promote the fw_file attribute from W/O to R/W. Writing to
> the attribute pushes firmware to the device as normal, but reading
> from it will now return the customer-assigned revision field as an
> unsigned integer (e.g. 256 = 1.0, 257 = 1.1 and so on).

No, let's not overload this attribute and instead create a dedicated
fw_version or similar read-only attribute to expose active firmware
version to userspace.

Thanks.

-- 
Dmitry
```