[PATCH] HID: logitech-hidpp: Add product ID for MX Ergo in Bluetooth mode

Subsystems: hid core layer, hid logitech drivers, hid++ logitech drivers, the rest

STALE2039d

3 messages, 3 authors, 2021-01-14 · open the first message on its own page

[PATCH] HID: logitech-hidpp: Add product ID for MX Ergo in Bluetooth mode

From: Nicholas Miell <hidden>
Date: 2021-01-11 06:10:09

The Logitech MX Ergo trackball supports HID++ 4.5 over Bluetooth. Add its
product ID to the table so we can get battery monitoring support.
(The hid-logitech-hidpp driver already recognizes it when connected via
a Unifying Receiver.)

Signed-off-by: Nicholas Miell <redacted>
---
 drivers/hid/hid-logitech-hidpp.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index f85781464807d..7eb9a6ddb46a6 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -4053,6 +4053,8 @@ static const struct hid_device_id hidpp_devices[] = {
        { /* MX Master mouse over Bluetooth */
          HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb012),
          .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
+       { /* MX Ergo trackball over Bluetooth */
+         HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb01d) },
        { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb01e),
          .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
        { /* MX Master 3 mouse over Bluetooth */
-- 
2.29.2

Re: [PATCH] HID: logitech-hidpp: Add product ID for MX Ergo in Bluetooth mode

From: Hans de Goede <hidden>
Date: 2021-01-11 10:52:13

Hi,

On 1/11/21 7:09 AM, Nicholas Miell wrote:
The Logitech MX Ergo trackball supports HID++ 4.5 over Bluetooth. Add its
product ID to the table so we can get battery monitoring support.
(The hid-logitech-hidpp driver already recognizes it when connected via
a Unifying Receiver.)

Signed-off-by: Nicholas Miell <redacted>
Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <redacted>

Regards,

Hans
quoted hunk
---
 drivers/hid/hid-logitech-hidpp.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index f85781464807d..7eb9a6ddb46a6 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -4053,6 +4053,8 @@ static const struct hid_device_id hidpp_devices[] = {
        { /* MX Master mouse over Bluetooth */
          HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb012),
          .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
+       { /* MX Ergo trackball over Bluetooth */
+         HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb01d) },
        { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb01e),
          .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
        { /* MX Master 3 mouse over Bluetooth */

Re: [PATCH] HID: logitech-hidpp: Add product ID for MX Ergo in Bluetooth mode

From: Jiri Kosina <jikos@kernel.org>
Date: 2021-01-14 12:27:22

On Sun, 10 Jan 2021, Nicholas Miell wrote:
The Logitech MX Ergo trackball supports HID++ 4.5 over Bluetooth. Add its
product ID to the table so we can get battery monitoring support.
(The hid-logitech-hidpp driver already recognizes it when connected via
a Unifying Receiver.)

Signed-off-by: Nicholas Miell <redacted>
Thanks for the patch. It was whitespace damaged by your mail client 
though. I've fixed it manually and applied, but please look into fixing 
this for any future patch submissions.

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help