# \[PATCH\]\[next\] Input: iqs5xx: Ensure error\_bl is initialized on error exit path - Subsystems: INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN) DRIVERS, THE REST - Maintainers: Dmitry Torokhov, Linus Torvalds - List: linux-input - 3 messages, 2 authors - Page: https://ratatoskr.run/linux-input/2021/01/6250841/t ## \[PATCH\]\[next\] Input: iqs5xx: Ensure error\_bl is initialized on error exit path - From: Colin King \ - Date: 2021-01-28 12:20:15 - Message: https://ratatoskr.run/linux-input/2021/01/6250841.md ```text From: Colin Ian King Currently if the call to qs5xx_fw_file_parse fails the error return exit path will read the uninitialized variable error_bl. Fix this by ensuring error_bl is initialized to zero. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 2539da6677b6 ("Input: iqs5xx - preserve bootloader errors") Signed-off-by: Colin Ian King --- drivers/input/touchscreen/iqs5xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/iqs5xx.c b/drivers/input/touchscreen/iqs5xx.c index 05e0c6ff217b..54f30038dca4 100644 --- a/drivers/input/touchscreen/iqs5xx.c +++ b/drivers/input/touchscreen/iqs5xx.c @@ -852,7 +852,7 @@ static int iqs5xx_fw_file_parse(struct i2c_client *client, static int iqs5xx_fw_file_write(struct i2c_client *client, const char *fw_file) { struct iqs5xx_private *iqs5xx = i2c_get_clientdata(client); - int error, error_bl; + int error, error_bl = 0; u8 *pmap; if (iqs5xx->bl_status == IQS5XX_BL_STATUS_NONE) -- 2.29.2 ``` ## Re: \[PATCH\]\[next\] Input: iqs5xx: Ensure error\_bl is initialized on error exit path - From: Jeff LaBundy \ - Date: 2021-01-28 14:41:04 - Message: https://ratatoskr.run/linux-input/2021/01/6250965.md ```text Hi Colin, On Thu, Jan 28, 2021 at 12:19:03PM +0000, Colin King wrote: > From: Colin Ian King > > Currently if the call to qs5xx_fw_file_parse fails the error return > exit path will read the uninitialized variable error_bl. Fix this > by ensuring error_bl is initialized to zero. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 2539da6677b6 ("Input: iqs5xx - preserve bootloader errors") > Signed-off-by: Colin Ian King This was fixed in [1]; it just needs pushed. [1] https://patchwork.kernel.org/patch/12043701 > --- > drivers/input/touchscreen/iqs5xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/iqs5xx.c b/drivers/input/touchscreen/iqs5xx.c > index 05e0c6ff217b..54f30038dca4 100644 > --- a/drivers/input/touchscreen/iqs5xx.c > +++ b/drivers/input/touchscreen/iqs5xx.c > @@ -852,7 +852,7 @@ static int iqs5xx_fw_file_parse(struct i2c_client *client, > static int iqs5xx_fw_file_write(struct i2c_client *client, const char *fw_file) > { > struct iqs5xx_private *iqs5xx = i2c_get_clientdata(client); > - int error, error_bl; > + int error, error_bl = 0; > u8 *pmap; > > if (iqs5xx->bl_status == IQS5XX_BL_STATUS_NONE) > -- > 2.29.2 > Kind regards, Jeff LaBundy ``` ## Re: \[PATCH\]\[next\] Input: iqs5xx: Ensure error\_bl is initialized on error exit path - From: Colin Ian King \ - Date: 2021-01-28 14:57:35 - Message: https://ratatoskr.run/linux-input/2021/01/6250991.md ```text On 28/01/2021 14:39, Jeff LaBundy wrote: > Hi Colin, > > On Thu, Jan 28, 2021 at 12:19:03PM +0000, Colin King wrote: >> From: Colin Ian King >> >> Currently if the call to qs5xx_fw_file_parse fails the error return >> exit path will read the uninitialized variable error_bl. Fix this >> by ensuring error_bl is initialized to zero. >> >> Addresses-Coverity: ("Uninitialized scalar variable") >> Fixes: 2539da6677b6 ("Input: iqs5xx - preserve bootloader errors") >> Signed-off-by: Colin Ian King > > This was fixed in [1]; it just needs pushed. OK, thanks for letting me know. > > [1] https://patchwork.kernel.org/patch/12043701 > >> --- >> drivers/input/touchscreen/iqs5xx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/input/touchscreen/iqs5xx.c b/drivers/input/touchscreen/iqs5xx.c >> index 05e0c6ff217b..54f30038dca4 100644 >> --- a/drivers/input/touchscreen/iqs5xx.c >> +++ b/drivers/input/touchscreen/iqs5xx.c >> @@ -852,7 +852,7 @@ static int iqs5xx_fw_file_parse(struct i2c_client *client, >> static int iqs5xx_fw_file_write(struct i2c_client *client, const char *fw_file) >> { >> struct iqs5xx_private *iqs5xx = i2c_get_clientdata(client); >> - int error, error_bl; >> + int error, error_bl = 0; >> u8 *pmap; >> >> if (iqs5xx->bl_status == IQS5XX_BL_STATUS_NONE) >> -- >> 2.29.2 >> > > Kind regards, > Jeff LaBundy > ```