DORMANTno replies

[PATCH][next] SFH: remove redundant initialization of pointer cl_data

From: Colin King <hidden>
Date: 2020-11-02 11:12:09
Also in: kernel-janitors, lkml
Subsystem: amd sensor fusion hub driver, hid core layer, the rest · Maintainers: Basavaraj Natikar, Jiri Kosina, Benjamin Tissoires, Linus Torvalds

From: Colin Ian King <redacted>

The pointer cl_data is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/hid/amd-sfh-hid/amd_sfh_client.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_client.c b/drivers/hid/amd-sfh-hid/amd_sfh_client.c
index 3d1ccac5d99a..7eaf519737c0 100644
--- a/drivers/hid/amd-sfh-hid/amd_sfh_client.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_client.c
@@ -133,7 +133,7 @@ static void amd_sfh_work_buffer(struct work_struct *work)
 
 int amd_sfh_hid_client_init(struct amd_mp2_dev *privdata)
 {
-	struct amdtp_cl_data *cl_data = privdata->cl_data;
+	struct amdtp_cl_data *cl_data;
 	struct amd_mp2_sensor_info info;
 	struct device *dev;
 	u32 feature_report_size;
-- 
2.27.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help