Re: [PATCH v4 3/3] dt-bindings: touchscreen: Add binding for Novatek NT36xxx series driver
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2020-10-08 18:21:53
Also in:
linux-devicetree, lkml, phone-devel
On Thu, 8 Oct 2020 at 20:15, [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: AngeloGioacchino Del Regno <redacted> Add binding for the Novatek NT36xxx series touchscreen driver. Signed-off-by: AngeloGioacchino Del Regno <redacted> --- .../input/touchscreen/novatek,nt36xxx.yaml | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/novatek,nt36xxx.yamldiff --git a/Documentation/devicetree/bindings/input/touchscreen/novatek,nt36xxx.yaml b/Documentation/devicetree/bindings/input/touchscreen/novatek,nt36xxx.yaml new file mode 100644 index 000000000000..e747cacae036 --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/novatek,nt36xxx.yaml@@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/touchscreen/novatek,nt36xxx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Novatek NT36xxx series touchscreen controller Bindings + +maintainers: + - Dmitry Torokhov <dmitry.torokhov@gmail.com> + +allOf: + - $ref: touchscreen.yaml# + +properties: + compatible: + const: novatek,nt36xxx
Thanks for the changes, they look good except this part here which I missed before. The compatible should not contain wildcards. If all devices are really compatible, just add here one const, e.g. "const: novatek,nt36525". If they are different, you could add multiple compatibles in enum. Best regards, Krzysztof