From: "Jason A. Donenfeld" <Jason@zx2c4.com> Date: 2020-09-25 16:42:54
With the new RMI4 F3A support posted yesterday, this appears to maybe
work, with a bootloader warning in dmesg:
psmouse serio1: synaptics: queried max coordinates: x [..5678], y [..4690]
psmouse serio1: synaptics: queried min coordinates: x [1266..], y [1160..]
psmouse serio1: synaptics: Trying to set up SMBus access
rmi4_smbus 0-002c: registering SMbus-connected sensor
--> rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version
--> rmi4_f34: probe of rmi4-00.fn34 failed with error -22
rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3512-010, fw id: 2956703
input: Synaptics TM3512-010 as /devices/rmi4-00/input/input91
serio: RMI4 PS/2 pass-through port at rmi4-00.fn03
psmouse serio4: trackpoint: Elan TrackPoint firmware: 0x11, buttons: 3/3
input: TPPS/2 Elan TrackPoint as /devices/rmi4-00/rmi4-00.fn03/serio4/input/input92
Cc: Lyude Paul <lyude@redhat.com>
Cc: Vincent Huang <redacted>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/input/mouse/synaptics.c | 1 +
1 file changed, 1 insertion(+)
With the new RMI4 F3A support posted yesterday, this appears to maybe
work, with a bootloader warning in dmesg:
psmouse serio1: synaptics: queried max coordinates: x [..5678], y [..4690]
psmouse serio1: synaptics: queried min coordinates: x [1266..], y [1160..]
psmouse serio1: synaptics: Trying to set up SMBus access
rmi4_smbus 0-002c: registering SMbus-connected sensor
--> rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version
--> rmi4_f34: probe of rmi4-00.fn34 failed with error -22
rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3512-010, fw id: 2956703
input: Synaptics TM3512-010 as /devices/rmi4-00/input/input91
serio: RMI4 PS/2 pass-through port at rmi4-00.fn03
psmouse serio4: trackpoint: Elan TrackPoint firmware: 0x11, buttons: 3/3
input: TPPS/2 Elan TrackPoint as /devices/rmi4-00/rmi4-00.fn03/serio4/input/input92
Cc: Lyude Paul <lyude@redhat.com>
Cc: Vincent Huang <redacted>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/input/mouse/synaptics.c | 1 +
1 file changed, 1 insertion(+)
From: "Jason A. Donenfeld" <Jason@zx2c4.com> Date: 2020-09-30 11:24:56
With the new RMI4 F3A support posted yesterday, this appears to maybe
work, but requires us to add support for the newer bootloader, which
this commit does.
Cc: Lyude Paul <lyude@redhat.com>
Cc: Vincent Huang <redacted>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/input/mouse/synaptics.c | 1 +
drivers/input/rmi4/rmi_f34v7.c | 7 +++++--
2 files changed, 6 insertions(+), 2 deletions(-)
From: Lyude Paul <lyude@redhat.com> Date: 2020-09-30 16:05:33
Maybe correct the comment in smbus_pnp_ids to reflect this handles both the X1
Extreme and P2 2nd Gen. Then I'd probably split the bootloader change into a
commit that comes before adding the new PnP IDs.
Otherwise though:
Acked-by: Lyude Paul <lyude@redhat.com>
Let's see what the folks from synaptics say
On Wed, 2020-09-30 at 13:24 +0200, Jason A. Donenfeld wrote:
quoted hunk
With the new RMI4 F3A support posted yesterday, this appears to maybe
work, but requires us to add support for the newer bootloader, which
this commit does.
Cc: Lyude Paul <lyude@redhat.com>
Cc: Vincent Huang <redacted>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/input/mouse/synaptics.c | 1 +
drivers/input/rmi4/rmi_f34v7.c | 7 +++++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c
b/drivers/input/mouse/synaptics.c
index 8a54efd6eb95..9d6fec84047b 100644
From: "Jason A. Donenfeld" <Jason@zx2c4.com> Date: 2020-09-30 16:18:24
On Wed, Sep 30, 2020 at 6:05 PM Lyude Paul [off-list ref] wrote:
Maybe correct the comment in smbus_pnp_ids to reflect this handles both the X1
Extreme and P2 2nd Gen. Then I'd probably split the bootloader change into a
commit that comes before adding the new PnP IDs.
Okay, I'll submit a v3.
One thing I should note is that the sensitivity sysfs entry doesn't
seem to do anything at all. push_to_click works, but not sensitivity.
I don't know if this has bitrotted over the years and I shouldn't
expect it to work, as it rarely does or something, but thought I
should mention this.
Jason
Otherwise though:
Acked-by: Lyude Paul <lyude@redhat.com>
Let's see what the folks from synaptics say
On Wed, 2020-09-30 at 13:24 +0200, Jason A. Donenfeld wrote:
quoted
With the new RMI4 F3A support posted yesterday, this appears to maybe
work, but requires us to add support for the newer bootloader, which
this commit does.
Cc: Lyude Paul <lyude@redhat.com>
Cc: Vincent Huang <redacted>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/input/mouse/synaptics.c | 1 +
drivers/input/rmi4/rmi_f34v7.c | 7 +++++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c
b/drivers/input/mouse/synaptics.c
index 8a54efd6eb95..9d6fec84047b 100644
From: Lyude Paul <lyude@redhat.com> Date: 2020-09-30 19:55:59
On Wed, 2020-09-30 at 18:18 +0200, Jason A. Donenfeld wrote:
On Wed, Sep 30, 2020 at 6:05 PM Lyude Paul [off-list ref] wrote:
quoted
Maybe correct the comment in smbus_pnp_ids to reflect this handles both the
X1
Extreme and P2 2nd Gen. Then I'd probably split the bootloader change into a
commit that comes before adding the new PnP IDs.
Okay, I'll submit a v3.
One thing I should note is that the sensitivity sysfs entry doesn't
seem to do anything at all. push_to_click works, but not sensitivity.
I don't know if this has bitrotted over the years and I shouldn't
expect it to work, as it rarely does or something, but thought I
should mention this.
Interesting-it's entirely possible that maybe the firmware on this trackpoint is
different from the previous ones (only mention this possibility since it looks
like at some point in time they switched over from using the legitimate IBM
trackpoint modules to getting other manufacturers to make them). I know the
sensitivity setting works on my laptop with PS/2 through RMI4 though.
Could you maybe enable rmi4 debugging by passing rmi_core.debug_flags=0xff when
you boot your machine and get me the dmesg output from that after you've tried
changing the sensitivity value? Not sure I could fix it, but it'd be interesting
to see what's happening on the ps/2 side here
Jason
quoted
Otherwise though:
Acked-by: Lyude Paul <lyude@redhat.com>
Let's see what the folks from synaptics say
On Wed, 2020-09-30 at 13:24 +0200, Jason A. Donenfeld wrote:
quoted
With the new RMI4 F3A support posted yesterday, this appears to maybe
work, but requires us to add support for the newer bootloader, which
this commit does.
Cc: Lyude Paul <lyude@redhat.com>
Cc: Vincent Huang <redacted>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/input/mouse/synaptics.c | 1 +
drivers/input/rmi4/rmi_f34v7.c | 7 +++++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c
b/drivers/input/mouse/synaptics.c
index 8a54efd6eb95..9d6fec84047b 100644
From: "Jason A. Donenfeld" <Jason@zx2c4.com> Date: 2020-09-30 22:51:00
These piggyback on the recent F3A support from Vincent Huang to add RMI4
support to the Thinkpad P1 gen 2 and the Thinkpad X1E gen 2.
Jason A. Donenfeld (2):
Input: synaptics-rmi4 - support bootloader v8 in f34v7
Input: synaptics - enable InterTouch for ThinkPad P1/X1E gen 2
drivers/input/mouse/synaptics.c | 3 ++-
drivers/input/rmi4/rmi_f34v7.c | 7 +++++--
2 files changed, 7 insertions(+), 3 deletions(-)
--
2.28.0
From: "Jason A. Donenfeld" <Jason@zx2c4.com> Date: 2020-09-30 22:51:02
With the recent addition of the F3A support, we can now accept
bootloader v8, which will help support recent Thinkpads.
Acked-by: Lyude Paul <lyude@redhat.com>
Cc: Vincent Huang <redacted>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/input/rmi4/rmi_f34v7.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
From: "Jason A. Donenfeld" <Jason@zx2c4.com> Date: 2020-09-30 22:51:04
With the new RMI4 F3A support, we're now able to enable full RMI4
support for this model. We also tidy up the comments a bit, as the X1E
is essentially the same computer as the P1.
Acked-by: Lyude Paul <lyude@redhat.com>
Cc: Vincent Huang <redacted>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/input/mouse/synaptics.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
From: "Jason A. Donenfeld" <Jason@zx2c4.com> Date: 2020-09-30 22:56:13
On Wed, Sep 30, 2020 at 9:55 PM Lyude Paul [off-list ref] wrote:
On Wed, 2020-09-30 at 18:18 +0200, Jason A. Donenfeld wrote:
quoted
On Wed, Sep 30, 2020 at 6:05 PM Lyude Paul [off-list ref] wrote:
quoted
Maybe correct the comment in smbus_pnp_ids to reflect this handles both the
X1
Extreme and P2 2nd Gen. Then I'd probably split the bootloader change into a
commit that comes before adding the new PnP IDs.
Okay, I'll submit a v3.
One thing I should note is that the sensitivity sysfs entry doesn't
seem to do anything at all. push_to_click works, but not sensitivity.
I don't know if this has bitrotted over the years and I shouldn't
expect it to work, as it rarely does or something, but thought I
should mention this.
Interesting-it's entirely possible that maybe the firmware on this trackpoint is
different from the previous ones (only mention this possibility since it looks
like at some point in time they switched over from using the legitimate IBM
trackpoint modules to getting other manufacturers to make them).
Yea, a bummer. The P1 gen 2 has an ELAN. Far cry from all the nice
features supported by the IBM ones.
I know the
sensitivity setting works on my laptop with PS/2 through RMI4 though.
Right. My prior P50 worked fine with it.
Could you maybe enable rmi4 debugging by passing rmi_core.debug_flags=0xff when
you boot your machine and get me the dmesg output from that after you've tried
changing the sensitivity value? Not sure I could fix it, but it'd be interesting
to see what's happening on the ps/2 side here
Sure. Writing 200 into sensitivity gives:
[28653.834012] rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Wrote f5 to
PS/2 passthrough address
[28653.834989] rmi4_smbus 0-002c: wrote 1 bytes at 0x02: 0 (f5)
[28653.848217] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received fa
from PS2 guest T: N P: N
[28653.848301] rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Wrote e2 to
PS/2 passthrough address
[28653.849079] rmi4_smbus 0-002c: wrote 1 bytes at 0x02: 0 (e2)
[28653.857787] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received fa
from PS2 guest T: N P: N
[28653.857868] rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Wrote 81 to
PS/2 passthrough address
[28653.858643] rmi4_smbus 0-002c: wrote 1 bytes at 0x02: 0 (81)
[28653.865220] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received fa
from PS2 guest T: N P: N
[28653.865285] rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Wrote 4a to
PS/2 passthrough address
[28653.866053] rmi4_smbus 0-002c: wrote 1 bytes at 0x02: 0 (4a)
[28653.872889] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received fa
from PS2 guest T: N P: N
[28653.872952] rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Wrote c8 to
PS/2 passthrough address
[28653.873927] rmi4_smbus 0-002c: wrote 1 bytes at 0x02: 0 (c8)
[28653.880331] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received fa
from PS2 guest T: N P: N
[28653.880397] rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Wrote f4 to
PS/2 passthrough address
[28653.881156] rmi4_smbus 0-002c: wrote 1 bytes at 0x02: 0 (f4)
[28653.888285] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received fa
from PS2 guest T: N P: N
Subsequently, moving the trackpoint around gives the usual output:
[28765.017676] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 05
from PS2 guest T: N P: N
[28765.017677] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received ff
from PS2 guest T: N P: N
[28765.025214] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 28
from PS2 guest T: N P: N
[28765.025216] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 06
from PS2 guest T: N P: N
[28765.025216] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received ff
from PS2 guest T: N P: N
[28765.050927] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 28
from PS2 guest T: N P: N
[28765.050929] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 05
from PS2 guest T: N P: N
[28765.050951] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received ff
from PS2 guest T: N P: N
[28765.050958] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 08
from PS2 guest T: N P: N
[28765.050959] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 04
from PS2 guest T: N P: N
[28765.050959] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 00
from PS2 guest T: N P: N
[28765.099642] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 18
from PS2 guest T: N P: N
[28765.099644] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received ff
from PS2 guest T: N P: N
[28765.099644] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 00
from PS2 guest T: N P: N
[28765.099651] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 18
from PS2 guest T: N P: N
[28765.099652] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received ff
from PS2 guest T: N P: N
[28765.099652] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 00
from PS2 guest T: N P: N
[28765.230269] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 08
from PS2 guest T: N P: N
[28765.230276] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 00
from PS2 guest T: N P: N
[28765.230279] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 01
from PS2 guest T: N P: N
[28765.270171] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 08
from PS2 guest T: N P: N
[28765.270178] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 00
from PS2 guest T: N P: N
[28765.270181] rmi4_f03 rmi4-00.fn03: rmi_f03_attention: Received 01
from PS2 guest T: N P: N
On Thu, Oct 01, 2020 at 12:50:45AM +0200, Jason A. Donenfeld wrote:
With the recent addition of the F3A support, we can now accept
bootloader v8, which will help support recent Thinkpads.
Acked-by: Lyude Paul <lyude@redhat.com>
Cc: Vincent Huang <redacted>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
On Thu, Oct 01, 2020 at 12:50:46AM +0200, Jason A. Donenfeld wrote:
quoted hunk
With the new RMI4 F3A support, we're now able to enable full RMI4
support for this model. We also tidy up the comments a bit, as the X1E
is essentially the same computer as the P1.
Acked-by: Lyude Paul <lyude@redhat.com>
Cc: Vincent Huang <redacted>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/input/mouse/synaptics.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
From: "Jason A. Donenfeld" <Jason@zx2c4.com> Date: 2020-10-07 15:55:19
Oddly, CPU usage seems exceedingly high when using the trackpoint, in
the rmi4 irq handler. Running perf-top indicates a hotspot in
i801_access calling "in (%dx),%al", which makes sense. I wonder:
is this a culprit of expensive accesses in general, which Sultan
(CC'd) has been working on? Or are we hitting something different
here? Improper IRQ masking in the i801 code?
Jason