# \[PATCH 00/29\] treewide: Convert comma separated statements - Subsystems: INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN) DRIVERS, INPUT MULTITOUCH (MT) PROTOCOL, 8390 NETWORK DRIVERS \[NE2000, 3C503, etc.\], ALPHA PORT, ARM/RISCPC ARCHITECTURE, BCACHE (BLOCK LAYER CACHE), BLOCK LAYER, BTTV VIDEO4LINUX DRIVER, CHAR and MISC DRIVERS, CPU POWER MONITORING SUBSYSTEM, DMA BUFFER SHARING FRAMEWORK, DOCUMENTATION, DOCUMENTATION PROCESS, DRBD DRIVER, DRM DRIVERS, DRM DRIVERS AND MISC GPU PATCHES, DRM DRIVERS FOR GMA500 (Poulsbo, Moorestown and derivative chipsets), FILESYSTEMS (VFS and infrastructure), FRAMEBUFFER LAYER, FREESCALE SOC FS\_ENET DRIVER, FUSE FILESYSTEM \[CORE\], HARDWARE MONITORING, INTEL DRM I915 DRIVER (Meteor Lake, DG2 and older excluding Poulsbo, Moorestown and derivative), INTEL MID (Mobile Internet Device) PLATFORM, KERNEL NFSD, SUNRPC, AND LOCKD SERVERS, KERNEL SELFTEST FRAMEWORK, LIBATA SUBSYSTEM (Serial and Parallel ATA drivers), LIBRARY CODE, MEDIA INPUT INFRASTRUCTURE (V4L/DVB), MEMORY TECHNOLOGY DEVICES (MTD), NETWORKING DRIVERS, NETWORKING \[GENERAL\], NETWORKING \[IPv4/IPv6\], NFS, SUNRPC, AND LOCKD CLIENTS, PCMCIA SUBSYSTEM, S390 ARCHITECTURE, SAA7134 VIDEO4LINUX DRIVER, SCSI SUBSYSTEM, SPARC + UltraSPARC (sparc/sparc64), STAGING - ATOMISP DRIVER, STAGING SUBSYSTEM, SYSTEM CONTROL \& POWER/MANAGEMENT INTERFACE (SCPI/SCMI) Message Protocol drivers, THE REST, ZSTD - Maintainers: Dmitry Torokhov, Henrik Rydberg, Richard Henderson, Matt Turner, Magnus Lindholm, Russell King, Coly Li, Kent Overstreet, Jens Axboe, Mauro Carvalho Chehab, Arnd Bergmann, Greg Kroah-Hartman, Thomas Renninger, Shuah Khan, Shuah Khan, John B. Wyatt IV, John B. Wyatt IV, John Kacur, Sumit Semwal, Christian König, Philipp Stanner, Jonathan Corbet, Philipp Reisner, Lars Ellenberg, Christoph Böhmwalder, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Patrik Jakobsson, Alexander Viro, Christian Brauner, Helge Deller, Pantelis Antoniou, Miklos Szeredi, Guenter Roeck, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Andy Shevchenko, Chuck Lever, Jeff Layton, Damien Le Moal, Niklas Cassel, Andrew Morton, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern, Ido Schimmel, Trond Myklebust, Anna Schumaker, Dominik Brodowski, Heiko Carstens, Vasily Gorbik, Alexander Gordeev, "James E.J. Bottomley", "Martin K. Petersen", Andreas Larsson, Hans de Goede, Sudeep Holla, Linus Torvalds, Nick Terrell, David Sterba - Series: 29 patches touching 46 files, +694/-382 - Status: PENDING · 8 of 29 landed - Pending, 8 of 29 landed. - List: linux-input - 4 messages, 3 authors - Page: https://ratatoskr.run/linux-input/2020/08/187270/t ## \[PATCH 00/29\] treewide: Convert comma separated statements - From: Joe Perches \ - Date: 2020-08-25 04:59:32 - Message: https://ratatoskr.run/linux-input/2020/08/187270.md ```text There are many comma separated statements in the kernel. See:https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2008201856110.2524@hadrien/ Convert the comma separated statements that are in if/do/while blocks to use braces and semicolons. Many comma separated statements still exist but those are changes for another day. Joe Perches (29): coding-style.rst: Avoid comma statements alpha: Avoid comma separated statements ia64: Avoid comma separated statements sparc: Avoid comma separated statements ata: Avoid comma separated statements drbd: Avoid comma separated statements lp: Avoid comma separated statements dma-buf: Avoid comma separated statements drm/gma500: Avoid comma separated statements drm/i915: Avoid comma separated statements hwmon: (scmi-hwmon): Avoid comma separated statements Input: MT - Avoid comma separated statements bcache: Avoid comma separated statements media: Avoid comma separated statements mtd: Avoid comma separated statements 8390: Avoid comma separated statements fs_enet: Avoid comma separated statements wan: sbni: Avoid comma separated statements s390/tty3270: Avoid comma separated statements scai/arm: Avoid comma separated statements media: atomisp: Avoid comma separated statements video: fbdev: Avoid comma separated statements fuse: Avoid comma separated statements reiserfs: Avoid comma separated statements lib/zlib: Avoid comma separated statements lib: zstd: Avoid comma separated statements ipv6: fib6: Avoid comma separated statements sunrpc: Avoid comma separated statements tools: Avoid comma separated statements Documentation/process/coding-style.rst | 17 + arch/alpha/kernel/pci_iommu.c | 8 +- arch/alpha/oprofile/op_model_ev4.c | 22 +- arch/alpha/oprofile/op_model_ev5.c | 8 +- arch/ia64/kernel/smpboot.c | 7 +- arch/sparc/kernel/smp_64.c | 7 +- drivers/ata/pata_icside.c | 21 +- drivers/block/drbd/drbd_receiver.c | 6 +- drivers/char/lp.c | 6 +- drivers/dma-buf/st-dma-fence.c | 7 +- drivers/gpu/drm/gma500/mdfld_intel_display.c | 44 ++- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 8 +- drivers/gpu/drm/i915/gt/intel_gt_requests.c | 6 +- .../gpu/drm/i915/gt/selftest_workarounds.c | 6 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 6 +- drivers/hwmon/scmi-hwmon.c | 6 +- drivers/input/input-mt.c | 11 +- drivers/md/bcache/bset.c | 12 +- drivers/md/bcache/sysfs.c | 6 +- drivers/media/i2c/msp3400-kthreads.c | 12 +- drivers/media/pci/bt8xx/bttv-cards.c | 6 +- drivers/media/pci/saa7134/saa7134-video.c | 7 +- drivers/mtd/devices/lart.c | 10 +- drivers/net/ethernet/8390/axnet_cs.c | 19 +- drivers/net/ethernet/8390/lib8390.c | 14 +- drivers/net/ethernet/8390/pcnet_cs.c | 6 +- .../ethernet/freescale/fs_enet/fs_enet-main.c | 11 +- drivers/net/wan/sbni.c | 101 +++--- drivers/s390/char/tty3270.c | 6 +- drivers/scsi/arm/cumana_2.c | 19 +- drivers/scsi/arm/eesox.c | 9 +- drivers/scsi/arm/powertec.c | 9 +- .../media/atomisp/pci/atomisp_subdev.c | 6 +- drivers/video/fbdev/tgafb.c | 12 +- fs/fuse/dir.c | 24 +- fs/reiserfs/fix_node.c | 36 ++- lib/zlib_deflate/deftree.c | 49 ++- lib/zstd/compress.c | 120 ++++--- lib/zstd/fse_compress.c | 24 +- lib/zstd/huf_compress.c | 6 +- net/ipv6/ip6_fib.c | 12 +- net/sunrpc/sysctl.c | 6 +- tools/lib/subcmd/help.c | 10 +- tools/power/cpupower/utils/cpufreq-set.c | 14 +- tools/testing/selftests/vm/gup_benchmark.c | 18 +- tools/testing/selftests/vm/userfaultfd.c | 296 +++++++++++------- 46 files changed, 694 insertions(+), 382 deletions(-) -- 2.26.0 ``` ## \[PATCH 12/29\] Input: MT - Avoid comma separated statements - From: Joe Perches \ - Date: 2020-08-25 04:57:13 - Message: https://ratatoskr.run/linux-input/2020/08/6081716.md ```text Use semicolons and braces. Signed-off-by: Joe Perches --- drivers/input/input-mt.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c index f699538bdac4..44fe6f2f063c 100644 --- a/drivers/input/input-mt.c +++ b/drivers/input/input-mt.c @@ -323,11 +323,14 @@ static int adjust_dual(int *begin, int step, int *end, int eq, int mu) p = begin + step; s = p == end ? f + 1 : *p; - for (; p != end; p += step) - if (*p < f) - s = f, f = *p; - else if (*p < s) + for (; p != end; p += step) { + if (*p < f) { + s = f; + f = *p; + } else if (*p < s) { s = *p; + } + } c = (f + s + 1) / 2; if (c == 0 || (c > mu && (!eq || mu > 0))) -- 2.26.0 ``` ## Re: \[PATCH 12/29\] Input: MT - Avoid comma separated statements - From: Dmitry Torokhov \ - Date: 2020-08-25 17:07:29 - Message: https://ratatoskr.run/linux-input/2020/08/6082546.md ```text On Mon, Aug 24, 2020 at 09:56:09PM -0700, Joe Perches wrote: > Use semicolons and braces. > > Signed-off-by: Joe Perches Applied, thank you. -- Dmitry ``` ## Re: \[PATCH 00/29\] treewide: Convert comma separated statements - From: Martin K. Petersen \ - Date: 2020-09-09 02:12:37 - Message: https://ratatoskr.run/linux-input/2020/09/188197.md ```text On Mon, 24 Aug 2020 21:55:57 -0700, Joe Perches wrote: > There are many comma separated statements in the kernel. > See:https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2008201856110.2524@hadrien/ > > Convert the comma separated statements that are in if/do/while blocks > to use braces and semicolons. > > Many comma separated statements still exist but those are changes for > another day. > > [...] Applied to 5.10/scsi-queue, thanks! [01/29] coding-style.rst: Avoid comma statements (no commit info) [02/29] alpha: Avoid comma separated statements (no commit info) [03/29] ia64: Avoid comma separated statements (no commit info) [04/29] sparc: Avoid comma separated statements (no commit info) [05/29] ata: Avoid comma separated statements (no commit info) [06/29] drbd: Avoid comma separated statements (no commit info) [07/29] lp: Avoid comma separated statements (no commit info) [08/29] dma-buf: Avoid comma separated statements (no commit info) [09/29] drm/gma500: Avoid comma separated statements (no commit info) [10/29] drm/i915: Avoid comma separated statements (no commit info) [11/29] hwmon: (scmi-hwmon): Avoid comma separated statements (no commit info) [12/29] Input: MT - Avoid comma separated statements (no commit info) [13/29] bcache: Avoid comma separated statements (no commit info) [14/29] media: Avoid comma separated statements (no commit info) [15/29] mtd: Avoid comma separated statements (no commit info) [16/29] 8390: Avoid comma separated statements (no commit info) [17/29] fs_enet: Avoid comma separated statements (no commit info) [18/29] wan: sbni: Avoid comma separated statements (no commit info) [19/29] s390/tty3270: Avoid comma separated statements (no commit info) [20/29] scsi: arm: Avoid comma separated statements https://git.kernel.org/mkp/scsi/c/a08a07326510 [21/29] media: atomisp: Avoid comma separated statements (no commit info) [22/29] video: fbdev: Avoid comma separated statements (no commit info) [23/29] fuse: Avoid comma separated statements (no commit info) [24/29] reiserfs: Avoid comma separated statements (no commit info) [25/29] lib/zlib: Avoid comma separated statements (no commit info) [26/29] lib: zstd: Avoid comma separated statements (no commit info) [27/29] ipv6: fib6: Avoid comma separated statements (no commit info) [28/29] sunrpc: Avoid comma separated statements (no commit info) [29/29] tools: Avoid comma separated statements (no commit info) -- Martin K. Petersen Oracle Linux Engineering ```