Thread (8 messages) 8 messages, 3 authors, 2020-05-28

Re: [PATCH] HID: multitouch: Remove MT_CLS_WIN_8_DUAL

From: Kai-Heng Feng <hidden>
Date: 2020-05-27 06:19:25
Also in: lkml

On May 26, 2020, at 16:43, Benjamin Tissoires [off-list ref] wrote:

On Tue, May 26, 2020 at 10:24 AM Jiri Kosina [off-list ref] wrote:
quoted
On Tue, 14 Apr 2020, Kai-Heng Feng wrote:
quoted
After commit c23e2043d5f7 ("HID: multitouch: do not filter mice nodes"),
MT_CLS_WIN_8 also supports mouse nodes, hence make MT_CLS_WIN_8_DUAL
redundant.

Remove MT_CLS_WIN_8_DUAL accordingly.
Benjamin, can I get your Ack on this one please?
Heh, funny enough I was trying to fix
https://bugzilla.kernel.org/show_bug.cgi?id=207235 and was pondering
this one too.

To fix #207235, I'll likely need to add a new class and quirk in
hid-multitouch. I can't really find a generic solution for now, and we
better have a local quirk for the 2 devices we currently have and
backport those to stable. However, this patch will likely conflict
(trivially), with the new quirks, so I was thinking:
- submitting my quick and dirty quirk and mark it to stable
- apply this one on top of it (this one really doesn't need to go to stable)

How does that sound?
Sounds good. I'll resend this patch once your patch lands in the tree.

Kai-Heng
Cheers,
Benjamin
quoted
Thanks,

--
Jiri Kosina
SUSE Labs
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help