[PATCH 1/2] Input: Add keycodes for keyboard backlight control

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE2399d

4 messages, 2 authors, 2020-03-03 · open the first message on its own page

[PATCH 1/2] Input: Add keycodes for keyboard backlight control

From: Rajat Jain <hidden>
Date: 2020-03-03 00:56:54

New keyboards can have backlight control keys. Allocating keycodes
for them. Such keyboards are already available in ChromeOS.

Signed-off-by: Rajat Jain <redacted>
---
 include/uapi/linux/input-event-codes.h | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index 0f1db1cccc3fd..e12a19dc30262 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -652,6 +652,10 @@
 /* Electronic privacy screen control */
 #define KEY_PRIVACY_SCREEN_TOGGLE	0x279
 
+/* Keyboard Backlight control */
+#define KEY_KBD_BKLIGHT_UP              0x280
+#define KEY_KBD_BKLIGHT_DOWN            0x281
+
 /*
  * Some keyboards have keys which do not have a defined meaning, these keys
  * are intended to be programmed / bound to macros by the user. For most
-- 
2.25.0.265.gbab2e86ba0-goog

[PATCH 2/2] Input: Allocate keycode for SNIP key

From: Rajat Jain <hidden>
Date: 2020-03-03 00:56:59

New chromeos keyboards have a "snip" key that is basically a selective
screenshot (allows a user to select an area of screen to be copied).
Allocate a keyvode for it.

Signed-off-by: Rajat Jain <redacted>
---
 include/uapi/linux/input-event-codes.h | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index e12a19dc30262..51f419657d044 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -656,6 +656,9 @@
 #define KEY_KBD_BKLIGHT_UP              0x280
 #define KEY_KBD_BKLIGHT_DOWN            0x281
 
+/* Selective Screenshot */
+#define KEY_SNIP                        0x282
+
 /*
  * Some keyboards have keys which do not have a defined meaning, these keys
  * are intended to be programmed / bound to macros by the user. For most
-- 
2.25.0.265.gbab2e86ba0-goog

Re: [PATCH 1/2] Input: Add keycodes for keyboard backlight control

From: Bastien Nocera <hadess@hadess.net>
Date: 2020-03-03 08:15:40

On Mon, 2020-03-02 at 16:56 -0800, Rajat Jain wrote:
quoted hunk
New keyboards can have backlight control keys. Allocating keycodes
for them. Such keyboards are already available in ChromeOS.

Signed-off-by: Rajat Jain <redacted>
---
 include/uapi/linux/input-event-codes.h | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/include/uapi/linux/input-event-codes.h
b/include/uapi/linux/input-event-codes.h
index 0f1db1cccc3fd..e12a19dc30262 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -652,6 +652,10 @@
 /* Electronic privacy screen control */
 #define KEY_PRIVACY_SCREEN_TOGGLE	0x279
 
+/* Keyboard Backlight control */
+#define KEY_KBD_BKLIGHT_UP              0x280
+#define KEY_KBD_BKLIGHT_DOWN            0x281
There's already KEY_KBDILLUMDOWN and KEY_KBDILLUMUP, used since the
aluminium PowerBook G4 in 2005 (commit
146a4b3bdfb5641bfbf975e29680b482b8b343ba)
+
 /*
  * Some keyboards have keys which do not have a defined meaning,
these keys
  * are intended to be programmed / bound to macros by the user. For
most

Re: [PATCH 1/2] Input: Add keycodes for keyboard backlight control

From: Rajat Jain <hidden>
Date: 2020-03-03 23:59:42

On Tue, Mar 3, 2020 at 12:15 AM Bastien Nocera [off-list ref] wrote:
On Mon, 2020-03-02 at 16:56 -0800, Rajat Jain wrote:
quoted
New keyboards can have backlight control keys. Allocating keycodes
for them. Such keyboards are already available in ChromeOS.

Signed-off-by: Rajat Jain <redacted>
---
 include/uapi/linux/input-event-codes.h | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/include/uapi/linux/input-event-codes.h
b/include/uapi/linux/input-event-codes.h
index 0f1db1cccc3fd..e12a19dc30262 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -652,6 +652,10 @@
 /* Electronic privacy screen control */
 #define KEY_PRIVACY_SCREEN_TOGGLE    0x279

+/* Keyboard Backlight control */
+#define KEY_KBD_BKLIGHT_UP              0x280
+#define KEY_KBD_BKLIGHT_DOWN            0x281
There's already KEY_KBDILLUMDOWN and KEY_KBDILLUMUP, used since the
aluminium PowerBook G4 in 2005 (commit
146a4b3bdfb5641bfbf975e29680b482b8b343ba)
Thank you for pointing out. Yes, I think those key codes will work for
me. I will use those instead.

Please consider this patch withdrawn.

Thanks & Best Regards,

Rajat Jain
quoted
+
 /*
  * Some keyboards have keys which do not have a defined meaning,
these keys
  * are intended to be programmed / bound to macros by the user. For
most
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help