From: Johnny Chuang <hidden> Date: 2020-02-27 01:13:29
From: Johnny Chuang <redacted>
This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event.
This information is needed in showing pressure/width radius.
Signed-off-by: Johnny Chuang <redacted>
---
drivers/input/touchscreen/elants_i2c.c | 1 +
1 file changed, 1 insertion(+)
From: Harry Cutts <hidden> Date: 2020-02-27 18:44:20
On Wed, 26 Feb 2020 at 17:13, Johnny Chuang [off-list ref] wrote:
From: Johnny Chuang <redacted>
This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event.
This information is needed in showing pressure/width radius.
Signed-off-by: Johnny Chuang <redacted>
---
drivers/input/touchscreen/elants_i2c.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Harry Cutts <redacted>
Harry Cutts
Chrome OS Touch/Input team
From: Peter Hutterer <hidden> Date: 2020-02-27 22:36:19
On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote:
quoted hunk
From: Johnny Chuang <redacted>
This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event.
This information is needed in showing pressure/width radius.
Signed-off-by: Johnny Chuang <redacted>
---
drivers/input/touchscreen/elants_i2c.c | 1 +
1 file changed, 1 insertion(+)
@@ -1309,6 +1309,7 @@ static int elants_i2c_probe(struct i2c_client *client,input_set_abs_params(ts->input,ABS_MT_PRESSURE,0,255,0,0);input_abs_set_res(ts->input,ABS_MT_POSITION_X,ts->x_res);input_abs_set_res(ts->input,ABS_MT_POSITION_Y,ts->y_res);+input_abs_set_res(ts->input,ABS_MT_TOUCH_MAJOR,1);
official resolution for absinfo is "units per mm", so a value of 3 would
mean 3mm, is that correct?
Not that it matters too much, since touch major is already all over the
place and needs userspace overrides for every device but it'd be nice to at
least make this useful out of the box on one device class.
Reviewed-by: Peter Hutterer <redacted>
otherwise
Cheers,
Peter
error = input_register_device(ts->input);
if (error) {
--
2.7.4
-----Original Message-----
From: Peter Hutterer [mailto:peter.hutterer@who-t.net]
Sent: Friday, February 28, 2020 6:36 AM
To: Johnny Chuang
Cc: Dmitry Torokhov; Benjamin Tissoires; linux-kernel@vger.kernel.org;
linux-input@vger.kernel.org; Johnny Chuang; Jennifer Tsai; James Chen;
Paul
Liang; Jeff Chuang
Subject: Re: [PATCH] Input: elants_i2c - Report resolution information for
touch
major
On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote:
quoted
From: Johnny Chuang <redacted>
This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event.
This information is needed in showing pressure/width radius.
Signed-off-by: Johnny Chuang <redacted>
---
drivers/input/touchscreen/elants_i2c.c | 1 +
1 file changed, 1 insertion(+)
official resolution for absinfo is "units per mm", so a value of 3 would
mean 3mm, is that correct?
Correct.
This resolution (1 unit/mm) is for all elan I2C touchscreen devices,
including the touchscreen devices in the future.
This information is from our firmware members.
Not that it matters too much, since touch major is already all over the
place and needs userspace overrides for every device but it'd be nice to
at
least make this useful out of the box on one device class.
Reviewed-by: Peter Hutterer <redacted>
otherwise
Cheers,
Peter
quoted
error = input_register_device(ts->input);
if (error) {
--
2.7.4
-----Original Message-----
From: Peter Hutterer [mailto:peter.hutterer@who-t.net]
Sent: Friday, February 28, 2020 6:36 AM
To: Johnny Chuang
Cc: Dmitry Torokhov; Benjamin Tissoires; linux-kernel@vger.kernel.org;
linux-input@vger.kernel.org; Johnny Chuang; Jennifer Tsai; James Chen;
Paul Liang; Jeff Chuang
Subject: Re: [PATCH] Input: elants_i2c - Report resolution information
for touch major
On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote:
quoted
From: Johnny Chuang <redacted>
This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR
event.
quoted
quoted
This information is needed in showing pressure/width radius.
Signed-off-by: Johnny Chuang <redacted>
---
drivers/input/touchscreen/elants_i2c.c | 1 +
1 file changed, 1 insertion(+)
official resolution for absinfo is "units per mm", so a value of 3
would mean 3mm, is that correct?
Correct.
This resolution (1 unit/mm) is for all elan I2C touchscreen devices,
including
the touchscreen devices in the future.
This information is from our firmware members.
Hi Peter / Benjamin,
Could you help to review and approve this patch?
quoted
Not that it matters too much, since touch major is already all over
the place and needs userspace overrides for every device but it'd be
nice to at least make this useful out of the box on one device class.
Reviewed-by: Peter Hutterer <redacted>
otherwise
Cheers,
Peter
quoted
error = input_register_device(ts->input);
if (error) {
--
2.7.4
-----Original Message-----
From: Peter Hutterer [mailto:peter.hutterer@who-t.net]
Sent: Friday, February 28, 2020 6:36 AM
To: Johnny Chuang
Cc: Dmitry Torokhov; Benjamin Tissoires;
linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; Johnny
Chuang; Jennifer Tsai; James Chen; Paul Liang; Jeff Chuang
Subject: Re: [PATCH] Input: elants_i2c - Report resolution
information for touch major
On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote:
quoted
From: Johnny Chuang <redacted>
This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR
event.
quoted
quoted
This information is needed in showing pressure/width radius.
Signed-off-by: Johnny Chuang <redacted>
---
drivers/input/touchscreen/elants_i2c.c | 1 +
1 file changed, 1 insertion(+)
official resolution for absinfo is "units per mm", so a value of 3
would mean 3mm, is that correct?
Correct.
This resolution (1 unit/mm) is for all elan I2C touchscreen devices,
including the touchscreen devices in the future.
This information is from our firmware members.
Hi Peter / Benjamin,
Could you help to review and approve this patch?
Hi Peter / Benjamin,
HP project Mordin mass production on 2020/3/10. ODM needs to upgrade new
image with this patch to verify.
Because ODM can not get the image link from Google, already delay verify
schedule.
Please help to review and approve this patch ASAP. Thank you very much.
quoted
quoted
Not that it matters too much, since touch major is already all over
the place and needs userspace overrides for every device but it'd be
nice to at least make this useful out of the box on one device class.
Reviewed-by: Peter Hutterer <redacted>
otherwise
Cheers,
Peter
quoted
error = input_register_device(ts->input);
if (error) {
--
2.7.4
From: Benjamin Tissoires <hidden> Date: 2020-03-06 17:45:44
On Thu, Feb 27, 2020 at 2:13 AM Johnny Chuang
[off-list ref] wrote:
From: Johnny Chuang <redacted>
This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event.
This information is needed in showing pressure/width radius.
Signed-off-by: Johnny Chuang <redacted>
---
Acked-by: Benjamin Tissoires <redacted>
Cheers,
Benjamin
On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote:
From: Johnny Chuang <redacted>
This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event.
This information is needed in showing pressure/width radius.
Signed-off-by: Johnny Chuang <redacted>