It is hard to say what KEY_SCREEN and KEY_ZOOM mean, but historically DVB
folks have used them to indicate switch to full screen mode. Later, they
converged on using KEY_ZOOM to switch into full screen mode and KEY)SCREEN
to control aspect ratio (see Documentation/media/uapi/rc/rc-tables.rst).
Let's commit to these uses, and define:
- KEY_FULL_SCREEN (and make KEY_ZOOM its alias)
- KEY_ASPECT_RATIO (and make KEY_SCREEN its alias)
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Please let me know how we want merge this. Some of patches can be applied
independently and I tried marking them as such, but some require new key
names from input.h
include/uapi/linux/input-event-codes.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
According to HUTRR37 usage 0x6d from the consumer usage page corresponds
to action that selects the next available supported aspect ratio option
on a device which outputs or displays video. However KEY_ZOOM means
activate "Full Screen" mode, KEY_ASPECT_RATIO should be used instead.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/hid/hid-input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
According to HUT 1.12 usage 0xb5 from the generic desktop page is reserved
for switching between external and internal display, so let's add the
mapping.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
This can be applied independently.
drivers/hid/hid-input.c | 8 ++++++++
1 file changed, 8 insertions(+)
According to HUTRR73 usages 0x79, 0x7a and 0x7c from the consumer page
correspond to Brightness Up/Down/Toggle keys, so let's add the mappings.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
This can be applied independently.
drivers/hid/hid-input.c | 4 ++++
1 file changed, 4 insertions(+)
According to HUT 1.12 usage 0x232 from the consumer page is reserved for
switching application between full screen and windowed mode, so let's add
the mapping.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
This needs the new key definition.
drivers/hid/hid-input.c | 1 +
1 file changed, 1 insertion(+)
According to HUTRR77 usage 0x29f from the consumer page is reserved for
the Desktop application to present all running user’s application windows.
Linux defines KEY_SCALE to request Compiz Scale (Expose) mode, so let's
add the mapping.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
This can be applied independently.
drivers/hid/hid-input.c | 2 ++
1 file changed, 2 insertions(+)
We defined better names for keys to activate full screen mode or
change aspect ratio (while keeping the existing keycodes to avoid
breaking userspace), so let's use them in the document.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Documentation/media/uapi/rc/rc-tables.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
It is hard to say what KEY_SCREEN and KEY_ZOOM mean, but historically DVB
folks have used them to indicate switch to full screen mode. Later, they
converged on using KEY_ZOOM to switch into full screen mode and KEY)SCREEN
to control aspect ratio (see Documentation/media/uapi/rc/rc-tables.rst).
Let's commit to these uses, and define:
- KEY_FULL_SCREEN (and make KEY_ZOOM its alias)
- KEY_ASPECT_RATIO (and make KEY_SCREEN its alias)
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Please let me know how we want merge this. Some of patches can be applied
independently and I tried marking them as such, but some require new key
names from input.h
Acked-by: Jiri Kosina <redacted>
for the HID changes, and feel free to take it through your tree as a
whole, I don't expect any major conflicts rising up from this.
Thanks,
--
Jiri Kosina
SUSE Labs
From: Benjamin Tissoires <hidden> Date: 2019-01-21 10:41:53
On Mon, Jan 21, 2019 at 11:11 AM Jiri Kosina [off-list ref] wrote:
On Fri, 18 Jan 2019, Dmitry Torokhov wrote:
quoted
It is hard to say what KEY_SCREEN and KEY_ZOOM mean, but historically DVB
folks have used them to indicate switch to full screen mode. Later, they
converged on using KEY_ZOOM to switch into full screen mode and KEY)SCREEN
to control aspect ratio (see Documentation/media/uapi/rc/rc-tables.rst).
Let's commit to these uses, and define:
- KEY_FULL_SCREEN (and make KEY_ZOOM its alias)
- KEY_ASPECT_RATIO (and make KEY_SCREEN its alias)
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Please let me know how we want merge this. Some of patches can be applied
independently and I tried marking them as such, but some require new key
names from input.h
Acked-by: Jiri Kosina <redacted>
Acked-by: Benjamin Tissoires <redacted>
for the HID changes, and feel free to take it through your tree as a
whole, I don't expect any major conflicts rising up from this.
Works for me too. My tests showed no issues, so that's OK from me.
Cheers,
Benjamin
On Mon, Jan 21, 2019 at 11:41:32AM +0100, Benjamin Tissoires wrote:
On Mon, Jan 21, 2019 at 11:11 AM Jiri Kosina [off-list ref] wrote:
quoted
On Fri, 18 Jan 2019, Dmitry Torokhov wrote:
quoted
It is hard to say what KEY_SCREEN and KEY_ZOOM mean, but historically DVB
folks have used them to indicate switch to full screen mode. Later, they
converged on using KEY_ZOOM to switch into full screen mode and KEY)SCREEN
to control aspect ratio (see Documentation/media/uapi/rc/rc-tables.rst).
Let's commit to these uses, and define:
- KEY_FULL_SCREEN (and make KEY_ZOOM its alias)
- KEY_ASPECT_RATIO (and make KEY_SCREEN its alias)
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Please let me know how we want merge this. Some of patches can be applied
independently and I tried marking them as such, but some require new key
names from input.h
Acked-by: Jiri Kosina <redacted>
Acked-by: Benjamin Tissoires <redacted>
Mauro, any objections on pushing the media doc patch through my tree?
Thanks.
--
Dmitry
On Fri, Jan 18, 2019 at 03:30:32PM -0800, Dmitry Torokhov wrote:
We defined better names for keys to activate full screen mode or
change aspect ratio (while keeping the existing keycodes to avoid
breaking userspace), so let's use them in the document.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Documentation/media/uapi/rc/rc-tables.rst | 4 ++--
Mauro, do you want to take this through your tree or I should pick it up
with the patch that does renames in uapi header?
Thanks!
Em Fri, 18 Jan 2019 15:30:31 -0800
Dmitry Torokhov [off-list ref] escreveu:
It is hard to say what KEY_SCREEN and KEY_ZOOM mean, but historically DVB
folks have used them to indicate switch to full screen mode. Later, they
converged on using KEY_ZOOM to switch into full screen mode and KEY)SCREEN
to control aspect ratio (see Documentation/media/uapi/rc/rc-tables.rst).
Let's commit to these uses, and define:
- KEY_FULL_SCREEN (and make KEY_ZOOM its alias)
- KEY_ASPECT_RATIO (and make KEY_SCREEN its alias)
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Feel free to apply via your tree.
Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
quoted hunk
---
Please let me know how we want merge this. Some of patches can be applied
independently and I tried marking them as such, but some require new key
names from input.h
include/uapi/linux/input-event-codes.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
Em Sun, 17 Feb 2019 23:26:06 -0800
Dmitry Torokhov [off-list ref] escreveu:
On Fri, Jan 18, 2019 at 03:30:32PM -0800, Dmitry Torokhov wrote:
quoted
We defined better names for keys to activate full screen mode or
change aspect ratio (while keeping the existing keycodes to avoid
breaking userspace), so let's use them in the document.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Documentation/media/uapi/rc/rc-tables.rst | 4 ++--
Mauro, do you want to take this through your tree or I should pick it up
with the patch that does renames in uapi header?
Feel free to apply it via your tree. It probably makes sense to keep it
with the series that add the new codes.
Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>